Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[quick_actions] Fixes Android action forwarding #1856

Merged
merged 5 commits into from Jul 16, 2019
Merged

[quick_actions] Fixes Android action forwarding #1856

merged 5 commits into from Jul 16, 2019

Conversation

juliocbcotta
Copy link
Contributor

Description

  • Fixes action forwarding by removing extra Activity.
  • Report shortcut usage to Android framework.
  • Improves example.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@juliocbcotta juliocbcotta mentioned this pull request Jul 16, 2019
Merged
13 tasks
@collinjackson collinjackson self-requested a review July 16, 2019 00:47
collinjackson
collinjackson reviewed Jul 16, 2019
View reviewed changes
packages/quick_actions/CHANGELOG.md
@@ -1,3 +1,8 @@
## 0.3.2+2
* Fix bug that would make the shortcut not open on Android.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it completely broken on Android or only in certain situations? I'd ideally like to test this plugin more but it will require a bit more progress on our Android testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reproduce the problem with the current master code.

  1. Open the app using the launcher.
  2. Exit the app using the Back button.
  3. Use the shortcut to open the app. ## There is no visual feedback of anything being done.

@collinjackson
Copy link
Contributor

I tested this manually in the simulator and it works.

@collinjackson collinjackson merged commit 63609c9 into flutter:master Jul 16, 2019
@juliocbcotta juliocbcotta deleted the plugin/quick_actions_fixes branch July 17, 2019 03:38
mithun-mondal pushed a commit to bKash-developer/plugins that referenced this pull request Aug 6, 2019
@juliocbcotta @mithun-mondal
[quick_actions] Fixes Android action forwarding (flutter#1856)
5d90783 
* - Fixes action forwarding by removing extra Activity.
- Report shortcut usage to Android framework.
- Improves example.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@juliocbcotta @collinjackson @googlebot