This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[instrumentation_adapter] enable Firebase Test Lab Android testing #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
changed the title
…d in a subsequent PR)
collinjackson
changed the title
digiter
reviewed
Aug 27, 2019
...entation_adapter/android/src/main/java/dev/flutter/instrumentationadapter/FlutterRunner.java
Outdated
Show resolved
Hide resolved
...entation_adapter/android/src/main/java/dev/flutter/instrumentationadapter/FlutterRunner.java
Show resolved
Hide resolved
packages/package_info/example/test_driver/package_info_test.dart
Outdated
Show resolved
Hide resolved
collinjackson
changed the title
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…lutter#1866) This pull request adds Firebase Test Lab Android instrumentation test adapter to the first-party plugins repo. Using the plugin requires calling `InstrumentationAdapterFlutterBinding.ensureInitialized` and using `testWidgets` rather than `test`. Furthermore, a Java test file must be added to the androidTest folder. Examples of this will be provided in a subsequent PR. Ultimately I'd like to refactor the common functionality into engine and see the "flutter create" template include the boilerplate files for running instrumentation tests automatically, but first we need to try them out a bit with plugins and iterate on usability. So I've put the functionality into a plugin. Joint work with @digiter
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…lutter#1866) This pull request adds Firebase Test Lab Android instrumentation test adapter to the first-party plugins repo. Using the plugin requires calling `InstrumentationAdapterFlutterBinding.ensureInitialized` and using `testWidgets` rather than `test`. Furthermore, a Java test file must be added to the androidTest folder. Examples of this will be provided in a subsequent PR. Ultimately I'd like to refactor the common functionality into engine and see the "flutter create" template include the boilerplate files for running instrumentation tests automatically, but first we need to try them out a bit with plugins and iterate on usability. So I've put the functionality into a plugin. Joint work with @digiter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Firebase Test Lab Android instrumentation test adapter to the first-party plugins repo.
Using the plugin requires calling
InstrumentationAdapterFlutterBinding.ensureInitializedand usingtestWidgetsrather thantest. Furthermore, a Java test file must be added to the androidTest folder. Examples of this will be provided in a subsequent PR.Ultimately I'd like to refactor the common functionality into engine and see the "flutter create" template include the boilerplate files for running instrumentation tests automatically, but first we need to try them out a bit with plugins and iterate on usability. So I've put the functionality into a plugin.
Joint work with @digiter
Example video (requires Flutter infra console access to view)
https://firebase.corp.google.com/u/0/project/flutter-infra/testlab/histories/bh.fd85a82ead1f4de/matrices/7844623689026548057/executions/bs.ac7032cef1ca34b9/videos
Related Issues
flutter/flutter#11718
Requires https://github.com/flutter/plugin_tools/pull/51 to land this
This PR originally had put Firebase Test Lab on Cirrus and added tests to other plugins, but that's been moved out to a separate PR for easier reviewing.