Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] Fix getIdToken refresh param on iOS #1869

Merged
merged 5 commits into from
Jul 18, 2019

Conversation

lukaspili
Copy link
Contributor

Description

The function getIdToken() takes a refresh parameter.
This parameter is ignored on iOS, and hardcoded refresh = true is used. This PR fixes that.
No changes required on Android, the refresh parameter is properly taken in account.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks challenging to integration test, so I'm going to go ahead and merge it without a test.

@collinjackson collinjackson merged commit 80e21e0 into flutter:master Jul 18, 2019
@lukaspili lukaspili deleted the fix_getidtoken_refresh_ios branch July 19, 2019 23:18
@lukaspili
Copy link
Contributor Author

Thanks for the quick review!

mithun-mondal pushed a commit to bKash-developer/plugins that referenced this pull request Aug 6, 2019
* Fix refresh param on getIdToken iOS.

* Update authors.
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Fix refresh param on getIdToken iOS.

* Update authors.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants