Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[device_info] Update and migrate iOS example project #2092

Merged
merged 2 commits into from
Sep 27, 2019
Merged

[device_info] Update and migrate iOS example project #2092

merged 2 commits into from
Sep 27, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 25, 2019 •
edited
Loading

Description

  1. Let Move flutter_assets to App.framework flutter#26630 flutter_assets migrator run
  2. Run pod install so flutter_assets is removed from the asset copy build phase
  3. Migrate deprecated "English" to "en" language
  4. Allow Xcode to remove extraneous xcconfigs, see Remove xcconfigs from template Copy Bundle Resources build phases flutter#38724
  5. Let Xcode 11 update build settings
  6. Remove ARCHS, which was causing a compilation error

Related Issues

Get to a buildable baseline so I can start working on flutter/flutter#41007.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jmagman
Copy link
Member Author

jmagman commented Sep 25, 2019

Does a change to the example app require a build suffix version bump?

@jmagman jmagman requested a review from mklim September 27, 2019 19:07
mklim
mklim approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklim mklim merged commit 7fe6934 into flutter:master Sep 27, 2019
@jmagman jmagman deleted the build-di branch September 27, 2019 19:18
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
@jmagman @mormih
[device_info] Update and migrate iOS example project (flutter#2092)
8eaeae9 
1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@jmagman
[device_info] Update and migrate iOS example project (flutter#2092)
9e8d48d 
1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mklim mklim mklim approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@jmagman @mklim @googlebot