This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Use url_launcher_platform_interface to handle calls
#2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
reviewed
Oct 23, 2019
| }); | ||
| } | ||
|
|
||
| class MockUrlLauncher extends Mock implements UrlLauncherPlatform {} |
There was a problem hiding this comment.
This was a red flag for me as I was planning to enforce that it's not implemented with implements.
I sent #2230 which leaves a back door for mocks.
| @@ -14,10 +14,13 @@ flutter: | |||
| dependencies: | |||
| flutter: | |||
| sdk: flutter | |||
| url_launcher_platform_interface: ^1.0.0 | |||
There was a problem hiding this comment.
If this lands after #2230 lets make this ^1.01
amirh
reviewed
Oct 23, 2019
|
|
||
| dev_dependencies: | ||
| flutter_test: | ||
| sdk: flutter | ||
| test: ^1.3.0 | ||
| mockito: ^3.0.0 |
There was a problem hiding this comment.
Seems like latest mockito is 4.1.1 any reason to use v3?
There was a problem hiding this comment.
No strong preference, just saw that ^3.0.0 was used in other plugins in this repo.
There was a problem hiding this comment.
Switched to ^4.1.1
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…lutter#2228) * [url_launcher] Use `url_launcher_platform_interface` to handle calls * Exclude platform interface from all-plugins-app * Update now that flutter#2230 has landed
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…lutter#2228) * [url_launcher] Use `url_launcher_platform_interface` to handle calls * Exclude platform interface from all-plugins-app * Update now that flutter#2230 has landed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward calls from
package:url_launcherto the platform-specific implementation declared inUrlLauncherPlatform.instance.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?