Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Added serviceTimeout code for google iab #2248

Closed
wants to merge 4 commits into from

Conversation

NikitaZhelonkin
Copy link

Fix for issue flutter/flutter#43969

@NikitaZhelonkin NikitaZhelonkin changed the title Added serviceTimeout code for google iab [in_app_purchase] Added serviceTimeout code for google iab Nov 1, 2019
@cyanglaz
Copy link
Contributor

@NikitaZhelonkin Thanks for spotting this. Could you reflect the change in the generated code as well? The steps to do so is mentioned in the comments above your change as well as in README.
Also we would need some tests before we can landing this.
Finally we would also need to update the CHANGELOG and pubspec with a new version.

@NikitaZhelonkin
Copy link
Author

@cyanglaz I had already added changes to generated code

@cyanglaz
Copy link
Contributor

@cyanglaz I had already added changes to generated code

Thanks a lot. We would also need tests and version update for this to be landed. Please let me know if you need any help :)

@NikitaZhelonkin
Copy link
Author

Am I need add test after adding only one enum value?

@cyanglaz
Copy link
Contributor

@NikitaZhelonkin Technically, we require all new PRs (If adding features or fixing bugs) to have tests. And I think a test for the enum case is pretty straight forward to add? Maybe we can just test if the json value for serviceTimeout is -3?

@cyanglaz
Copy link
Contributor

Closing this as #3287 has been landed and issue resolved.

@cyanglaz cyanglaz closed this Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants