This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Migrate plugins to use e2e tests. #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2019 10:46
cyanglaz
commented
Nov 15, 2019
| @@ -307,15 +302,15 @@ void main() { | |||
| expect(scrollGesturesEnabled, true); | |||
| }); | |||
|
|
|||
| test('testGetVisibleRegion', () async { | |||
| testWidgets('testGetVisibleRegion', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
@iskakaushik Could you please review the changes in this test. Since there are some tiny modifications of the original test.
collinjackson
approved these changes
Nov 15, 2019
cyanglaz
force-pushed
the
convert_to_e2e
branch
from
6728961
to
2305372
Compare
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the plugins are still use the old integration test. This PR migrates all of those to use the new e2e tests.
Landing this PR is required if we want to land https://github.com/flutter/plugin_tools/pull/64
Related Issues
flutter/flutter#44450
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?