Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Migrate to new pubspec plugins schema #2371

Merged
merged 12 commits into from
Dec 11, 2019
Merged

[google_sign_in] Migrate to new pubspec plugins schema #2371

merged 12 commits into from
Dec 11, 2019

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Dec 6, 2019

@cyanglaz cyanglaz requested a review from amirh December 6, 2019 23:56
amirh
amirh reviewed Dec 9, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure to either to first add an android folder for the web plugin, or land this without endorsing web

amirh
amirh approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please get @hterkelsen's approval as well

packages/google_sign_in/google_sign_in/CHANGELOG.md Outdated
## 4.1.0

* Support web by default.
* Use the new plugins pubspec schema.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this line

@harryterkelsen
Copy link
Contributor

Please bump the minimum version of google_sign_in_web to 0.8.2. Also please enable web support in the example by adding a web/index.html under the example/ directory containing this:

<!DOCTYPE html>
<html>
<head>
  <meta charset="UTF-8">
  <meta name="google-signin-client_id" content="159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com" />
  <title>Google Sign-in Example</title>
</head>
<body>
  <script src="main.dart.js" type="application/javascript"></script>
</body>
</html>

@cyanglaz
Copy link
Contributor Author

@hterkelsen done!

harryterkelsen
harryterkelsen approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit 1e82c75 into flutter:master Dec 11, 2019
eugenejeonme added a commit to COMANDKEYINC/flutter_plugins that referenced this pull request Dec 11, 2019
@eugenejeonme
Revert "[google_sign_in] Migrate to new pubspec plugins schema (flutt…
60c3f3a 
…er#2371)"

This reverts commit 1e82c75.

# Conflicts:
#	packages/google_sign_in/google_sign_in/CHANGELOG.md
#	packages/google_sign_in/google_sign_in/pubspec.yaml
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
[google_sign_in] Migrate to new pubspec plugins schema (flutter#2371)
4b810f1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amirh amirh amirh approved these changes

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@cyanglaz @harryterkelsen @amirh @googlebot