This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[shared_preferences] Endorse web plugin. #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Dec 10, 2019
| # validation, so we set a ^ constraint. | ||
| # TODO(amirh): Revisit this (either update this part in the design or the pub tool). | ||
| # https://github.com/flutter/flutter/issues/46264 | ||
| shared_preferences_web: ^0.1.1 |
There was a problem hiding this comment.
I'd bump shared_preferences_web to 0.1.2, so you can do ^0.1.2 here.
(Because there was a problem with ^0.1.1+1 right?)
ditman
approved these changes
Dec 10, 2019
eugenejeonme
added a commit
to COMANDKEYINC/flutter_plugins
that referenced
this pull request
Dec 11, 2019
This reverts commit fc2ea9f. # Conflicts: # packages/shared_preferences/shared_preferences/CHANGELOG.md # packages/shared_preferences/shared_preferences/pubspec.yaml
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* Make shared_preferences example work on web * [shared_preferences] Endorse web plugin * format pubspec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Endorse the web plugin in
shared_preferences.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?