[url_launcher_web] Added support for mailto in url_launcher_web plugin #2490
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@amirh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @hterkelsen? (Do you know what's that branch-guard
check that is failing?)
branch-guard is supposed to guard against landing PRs while the tree is red, it was introduced in #2492 and reverted quickly after (as it had a bug). I'm not sure why it shows here, feel free to ignore it for now as long as you manually check that the tree is green (rebasing may make that check go away). |
@amirh makes sense, thanks for the explanation! Maybe this PR was created while 2492 was active. |
The tree is currently green, I'm merging this as per @amirh comment. |
Tagged and published to pub.dev: https://pub.dev/packages/url_launcher_web/versions/0.1.1 |
flutter#2490) * Unit tests * Updated version and CHANGELOG
flutter#2490) * Unit tests * Updated version and CHANGELOG
flutter#2490) * Unit tests * Updated version and CHANGELOG
Description
Adds support for opening mailto links in url_launcher_web using the default browser behaviour.
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?