Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Add steps to set up google map sdk on each platform in readme. #2507

Merged
merged 2 commits into from Feb 7, 2020

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Feb 7, 2020

People seem to have trouble stepping up Google Map SDKs(issue here: flutter/flutter#30649). We should make our set up guide clearer.

Comment on lines 29 to 36
* Enable Google Map SDK for each platform.
* Go to [Google Developers Console](https://console.cloud.google.com/).
* Choose the project that you want to enable Google Maps on.
* Select the navigation menu and then select "Google Maps".
* Select "APIs" under the Google Maps menu.
* To enable Google Map for Android, select "Maps SDK for Android" in the "Additional APIs" section, then select "ENABLE".
* To enable Google Map for iOS, select "Maps SDK for iOS" in the "Additional APIs" section, then select "ENABLE".
* Make sure the APIs you enabled are under the "Enabled APIs" section.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a potential to be a maintenance burden if the GDC undergoes a big update, which I doubt would happen every frequently. Should we mention that this steps might be out of date? cc @amirh

@cyanglaz cyanglaz requested a review from amirh February 7, 2020 19:13
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits

* Choose the project that you want to enable Google Maps on.
* Select the navigation menu and then select "Google Maps".
* Select "APIs" under the Google Maps menu.
* To enable Google Map for Android, select "Maps SDK for Android" in the "Additional APIs" section, then select "ENABLE".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Google Maps

* Select the navigation menu and then select "Google Maps".
* Select "APIs" under the Google Maps menu.
* To enable Google Map for Android, select "Maps SDK for Android" in the "Additional APIs" section, then select "ENABLE".
* To enable Google Map for iOS, select "Maps SDK for iOS" in the "Additional APIs" section, then select "ENABLE".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

* To enable Google Map for iOS, select "Maps SDK for iOS" in the "Additional APIs" section, then select "ENABLE".
* Make sure the APIs you enabled are under the "Enabled APIs" section.

* You can also find a detailed steps to get start with Google Maps Platform [here](https://developers.google.com/maps/gmp-get-started).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "...find detailed steps"

@cyanglaz cyanglaz merged commit 619392d into flutter:master Feb 7, 2020
@cyanglaz cyanglaz deleted the google_maps_readme branch February 7, 2020 21:45
sanekyy pushed a commit to sanekyy/plugins that referenced this pull request Feb 18, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants