Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Exclude connectivity packages #2529

Merged
merged 1 commit into from Feb 14, 2020
Merged

Exclude connectivity packages #2529

merged 1 commit into from Feb 14, 2020

Conversation

franciscojma86
Copy link
Contributor

Includes connectivity_platform_interface connectivity_macos connectivity_web to avoid build failures caused by path dependencies.

Related Issues

flutter/flutter#46307

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@franciscojma86
Exclude connectivity packages
fb2de16 
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
mklim
mklim approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

collinjackson
collinjackson approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@collinjackson collinjackson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but noting that we could probably parse the pubspec.yaml and detect path dependencies another way so that this won't happen every time we federate a plugin.

@ditman
Copy link
Member

ditman commented Feb 14, 2020 •
edited

@collinjackson In this case it seems that this just needs to ignore the non-core plugin packages). Can we just ignore "everything that ends in _platform_interface or _[known_platform_name]"? (There's other packages that don't follow that pattern in the ignore list, though)

@ditman
Copy link
Member

ditman commented Feb 14, 2020

(Re-running failed checks to merge on green)

ditman
ditman approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

script/build_all_plugins_app.sh
@@ -11,6 +11,9 @@ source "$SCRIPT_DIR/common.sh"
check_changed_packages > /dev/null

readonly EXCLUDED_PLUGINS_LIST=(
"connectivity_macos"
"connectivity_platform_interface"
"connectivity_web"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for future-proofing this! :P

@franciscojma86
Copy link
Contributor Author

Landing since all tests are green in the Cirrus dashboard. There might be something wrong with the Github hooks https://cirrus-ci.com/task/5052116435730432

@franciscojma86 franciscojma86 merged commit e67c7fa into master Feb 14, 2020
sanekyy pushed a commit to sanekyy/plugins that referenced this pull request Feb 18, 2020
@franciscojma86 @sanekyy
Exclude connectivity packages (flutter#2529)
e16583e 
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
@franciscojma86 @EdwinRomelta
Exclude connectivity packages (flutter#2529)
45d00db 
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
@bparrishMines bparrishMines deleted the exclude-conn branch September 21, 2020 16:44
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@franciscojma86
Exclude connectivity packages (flutter#2529)
6e04f44 
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@ditman ditman ditman approved these changes

@mklim mklim mklim approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
5 participants
@franciscojma86 @ditman @collinjackson @mklim @googlebot