Conversation
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but noting that we could probably parse the pubspec.yaml and detect path dependencies another way so that this won't happen every time we federate a plugin.
@collinjackson In this case it seems that this just needs to ignore the non-core plugin packages). Can we just ignore "everything that ends in |
(Re-running failed checks to merge on green) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -11,6 +11,9 @@ source "$SCRIPT_DIR/common.sh" | |||
check_changed_packages > /dev/null | |||
|
|||
readonly EXCLUDED_PLUGINS_LIST=( | |||
"connectivity_macos" | |||
"connectivity_platform_interface" | |||
"connectivity_web" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for future-proofing this! :P
Landing since all tests are green in the Cirrus dashboard. There might be something wrong with the Github hooks https://cirrus-ci.com/task/5052116435730432 |
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
Includes `connectivity_platform_interface` `connectivity_macos` `connectivity_web` to avoid build failures caused by path dependencies.
Includes
connectivity_platform_interface
connectivity_macos
connectivity_web
to avoid build failures caused by path dependencies.Related Issues
flutter/flutter#46307
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?