This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Handle all images through URI #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
changed the title
cyanglaz
commented
May 1, 2020
| @@ -147,6 +42,7 @@ private static String getPathFromRemoteUri(final Context context, final Uri uri) | |||
| String extension = getImageExtension(uri); | |||
| inputStream = context.getContentResolver().openInputStream(uri); | |||
| file = File.createTempFile("image_picker", extension, context.getCacheDir()); | |||
| file.deleteOnExit(); | |||
There was a problem hiding this comment.
This is a new change to the previous code. I think we really should just try to delete the temp file after the virtual machine exits.
There was a problem hiding this comment.
+1 Especially since these files can get large.
Although this would imply the apps should not be storing the File URI anywhere. I don't think we currently recommend that in the documentation. We should fix that.
There was a problem hiding this comment.
Good point, will update the doc as well!
cyanglaz
changed the title
cyanglaz
changed the title
xster
reviewed
May 4, 2020
| assertTrue(path.contains("image_picker")); | ||
| assertTrue(path.contains("png")); | ||
| assertTrue(path.contains("/cache/")); | ||
| } |
There was a problem hiding this comment.
you "may" be able to just read from the path and assert that the content are the bytes for the string imageStream too
|
Great. Thanks for adding the test. LGTM |
mehmetf
approved these changes
May 4, 2020
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some historical reason, we have separated the diverged the code to different paths when handling different types of image data. Really, we should always handle the picked image through an URI like what we have been doing for remote images.
This way we can make sure the image picked from URI is definitely usable in the APP.
We don't seem to have a good way to test changes around this code base. I will keep looking into ways to test with JUnit
I have manually tested with downloaded images, images taken from camera, and images from google driver.
Tested with pixel a3 android 11, and some older android builds in emulators.
Related Issues
b/155138680
flutter/flutter#41459
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?