Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[connectivity] remove android no-op implementation #2784

Merged
merged 2 commits into from May 27, 2020

Conversation

cg021
Copy link
Contributor

@cg021 cg021 commented May 20, 2020

Description

Remove the Android directory in the connectivity's connectivity_macos subdirectory. This is an unused implementation and does not need to be included.

Related Issues

flutter/flutter#46304

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cg021 cg021 requested a review from blasten May 20, 2020 21:13
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the lastest version in CHANGELOG.md is 0.1.0+4, but in pubspec.yaml is 0.1.0+3. cc @stuartmorgan

This is causing presubmit failures.

@cg021 cg021 merged commit 5f0f9c0 into flutter:master May 27, 2020
@cg021 cg021 deleted the fix/46304-connectivity branch May 27, 2020 00:36
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
* remove android no-op implementation

* update pubspec.yaml and changelog versioning
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
* remove android no-op implementation

* update pubspec.yaml and changelog versioning
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
* remove android no-op implementation

* update pubspec.yaml and changelog versioning
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants