This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[path_provider] Add Windows support #2818
[path_provider] Add Windows support #2818
Changes from 31 commits
7e018b9
712c043
55429f6
52d5b0d
aea6a4c
f20a00e
1be04d7
306868e
cd0ea88
0eba356
06bd98f
383ef8f
ad0c2b9
f264046
03a126e
5057d47
9da128b
37eba73
a3a2d41
6048f43
30ef537
ca07f04
41c704e
d017a20
22afc78
bd11efc
3cd2f98
3d49b16
845074f
a3c2bf2
676fd02
cd2f366
7d46f63
80a0b6a
3a3fdb7
954a8df
be299b9
e826b17
370f3ce
fe6d472
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a separate sample for Windows? won't the normal path_provider sample do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an open question in the longer term about how to best structure the tests and examples for federated plugins. The plugin repo tooling expects them though, and it does have value in the general case:
So long term, TBD, short term, this is the standard practice we've been following.