Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[shared_preferences_linux] Add support for Linux #2836

Merged
merged 13 commits into from
Jun 30, 2020

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jun 18, 2020

Description

Adds shared_preferences support for Linux.

Related Issues

Part of flutter/flutter#41720

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@robert-ancell
Copy link
Contributor Author

I haven't worked out how to run test/shared_preferences_linux_test.dart - I tried flutter drive but couldn't work out how to get that work, either on this or path_provider_linux. All the different packages seem to have slightly different test layouts and I'm not sure what that "correct" method is.

The example program compiles and runs in Linux.

@stuartmorgan
Copy link
Contributor

I haven't worked out how to run test/shared_preferences_linux_test.dart - I tried flutter drive but couldn't work out how to get that work, either on this or path_provider_linux.

Hm, https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md#integration-tests should work. That's what the CI scripts are doing.

But the Linux CI run passed, so it looks like it's in good shape.

@robert-ancell
Copy link
Contributor Author

Note I updated the example to use shared_preferences_linux directly instead of shared_preferences. I think that makes sense based on the ordering you've suggested!?

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll land this now, and publish it once post-submit is green.

@stuartmorgan stuartmorgan merged commit e08b09c into flutter:master Jun 30, 2020
@stuartmorgan
Copy link
Contributor

It's live and ready to be endorsed!

@robert-ancell robert-ancell deleted the linux-shared-preferences branch July 1, 2020 03:18
agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants