Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] VideoPlayerPlugin.java uses or overrides a deprecated API #3019

Merged
merged 2 commits into from Sep 17, 2020
Merged

[video_player] VideoPlayerPlugin.java uses or overrides a deprecated API #3019

merged 2 commits into from Sep 17, 2020

Conversation

hamdikahloun
Copy link
Member

@hamdikahloun hamdikahloun commented Sep 11, 2020

Description

  • Handle deprecation & unchecked warning as error

  • Avoiding uses or overrides a deprecated API in VideoPlayerPlugin.java

Related issue:
flutter/flutter#65970

A message is displayed when building for android:

flutter build apk
You are building a fat APK that includes binaries for android-arm, android-arm64, android-x64.
If you are deploying the app to the Play Store, it's recommended to use app bundles or split the APK to reduce the APK
size.
    To generate an app bundle, run:
        flutter build appbundle --target-platform android-arm,android-arm64,android-x64
        Learn more on: https://developer.android.com/guide/app-bundle
    To split the APKs per ABI, run:
        flutter build apk --target-platform android-arm,android-arm64,android-x64 --split-per-abi
        Learn more on:  https://developer.android.com/studio/build/configure-apk-splits#configure-abi-split
Note: C:\Users\hamdi\Downloads\plugins-master\packages\video_player\video_player\android\src\main\java\io\flutter\plugins\videoplayer\VideoPlayerPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Removed unused resources: Binary resource data reduced from 46KB to 37KB: Removed 20%
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                      62,1s
√ Built build\app\outputs\flutter-apk\app-release.apk (18.7MB).
flutter build appbundle
Running "flutter pub get" in example...                             1,0s
Note: C:\Users\hamdi\Downloads\plugins-master\packages\video_player\video_player\android\src\main\java\io\flutter\plugins\videoplayer\VideoPlayerPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Removed unused resources: Binary resource data reduced from 36KB to 22KB: Removed 39%
Running Gradle task 'bundleRelease'...
Running Gradle task 'bundleRelease'... Done                        59,5s
√ Built build\app\outputs\bundle\release\app.aab (19.0MB).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit 40d2070 into flutter:master Sep 17, 2020
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants