[android_alarm_manager] Android Code Inspection and Clean up #3020

hamdikahloun · 2020-09-11T12:06:51Z

Description

Handle deprecation & unchecked warning as error
Avoiding uses or overrides a deprecated API in FlutterBackgroundExecutor.java
'while' loop replaced with enhanced 'for'
'if' statement replaced with 'switch' statement
Remove Unnecessary 'Integer.toString()' call

A message is displayed when building for android:

flutter build apk
Running "flutter pub get" in example...                             1,0s
You are building a fat APK that includes binaries for android-arm, android-arm64, android-x64.
If you are deploying the app to the Play Store, it's recommended to use app bundles or split the APK to reduce the APK
size.
    To generate an app bundle, run:
        flutter build appbundle --target-platform android-arm,android-arm64,android-x64
        Learn more on: https://developer.android.com/guide/app-bundle
    To split the APKs per ABI, run:
        flutter build apk --target-platform android-arm,android-arm64,android-x64 --split-per-abi
        Learn more on:  https://developer.android.com/studio/build/configure-apk-splits#configure-abi-split
Note: C:\Users\hamdi\Downloads\plugins-master\packages\android_alarm_manager\android\src\main\java\io\flutter\plugins\androidalarmmanager\FlutterBackgroundExecutor.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: C:\Users\hamdi\AppData\Local\Pub\Cache\hosted\pub.dartlang.org\espresso-0.0.1+5\android\src\main\java\androidx\test\espresso\flutter\EspressoFlutter.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Removed unused resources: Binary resource data reduced from 623KB to 581KB: Removed 6%
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                     104,3s
√ Built build\app\outputs\flutter-apk\app-release.apk (16.4MB).

flutter build appbundle
Running "flutter pub get" in example...                             1,1s
Note: C:\Users\hamdi\Downloads\plugins-master\packages\android_alarm_manager\android\src\main\java\io\flutter\plugins\androidalarmmanager\FlutterBackgroundExecutor.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: C:\Users\hamdi\AppData\Local\Pub\Cache\hosted\pub.dartlang.org\espresso-0.0.1+5\android\src\main\java\androidx\test\espresso\flutter\EspressoFlutter.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Removed unused resources: Binary resource data reduced from 461KB to 405KB: Removed 12%
Running Gradle task 'bundleRelease'...
Running Gradle task 'bundleRelease'... Done                        78,5s
√ Built build\app\outputs\bundle\release\app.aab (16.5MB).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

dnfield · 2020-09-12T17:57:30Z

packages/android_alarm_manager/android/gradle.properties

@@ -1 +1,2 @@
 org.gradle.jvmargs=-Xmx1536M
+android.enableR8=true


I don't think we want this as part of this patch

it's good, android.enableR8=true removed

dnfield · 2020-09-12T17:58:30Z

packages/android_alarm_manager/android/gradle/wrapper/gradle-wrapper.properties

@@ -0,0 +1,5 @@
+distributionBase=GRADLE_USER_HOME
+distributionPath=wrapper/dists


Did you mean to add this file?

no, i will fix it now and push again , Thank you @dnfield

it's good, I took care of all the comments

dnfield · 2020-09-12T17:58:47Z

...alarm_manager/android/src/main/java/io/flutter/plugins/androidalarmmanager/AlarmService.java

-      Iterator<Intent> i = alarmQueue.iterator();
-      while (i.hasNext()) {
-        flutterBackgroundExecutor.executeDartCallbackInBackgroundIsolate(i.next(), null);
+      /// 'while' loop replaceable with enhanced 'for'


Please remove thes e comments

ah sorry my bad

i juste removed all e commants like

/// 'while' loop replaceable with enhanced 'for'

dnfield

LGTM, thanks!

…#3020) -Werror and code cleanup for Java code.

hamdikahloun added 2 commits September 11, 2020 12:40

[android_alarm_manager] Code Inspection

6125d11

[android_alarm_manager] Update changelog & pubspec

168b6e9

hamdikahloun requested a review from bkonyi as a code owner September 11, 2020 12:06

googlebot added the cla: yes label Sep 11, 2020

hamdikahloun added 5 commits September 11, 2020 13:30

[android_alarm_manager] Format Code

319fd99

[android_alarm_manager] Update changelog & pubspec

c48594a

[android_alarm_manager] Update changelog & pubspec

b7ca834

Handle deprecation & unchecked warning as error

56b875c

Handle deprecation & unchecked warning as error

22f3d8f

dnfield reviewed Sep 12, 2020

View reviewed changes

hamdikahloun and others added 2 commits September 12, 2020 19:05

Handle deprecation & unchecked warning as error

73dbdfc

Update gradle.properties

0e3b4e5

hamdikahloun requested a review from dnfield September 12, 2020 18:09

dnfield approved these changes Sep 12, 2020

View reviewed changes

dnfield merged commit 4eb849a into flutter:master Sep 14, 2020

cyanglaz mentioned this pull request Sep 14, 2020

[android_alarm_manager] version fix #3028

Merged

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020

[android_alarm_manager] Android Code Inspection and Clean up (flutter…

5589616

…#3020) -Werror and code cleanup for Java code.

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[android_alarm_manager] Android Code Inspection and Clean up (flutter…

80262d7

…#3020) -Werror and code cleanup for Java code.

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[android_alarm_manager] Android Code Inspection and Clean up (flutter…

3345d94

…#3020) -Werror and code cleanup for Java code.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android_alarm_manager] Android Code Inspection and Clean up #3020

[android_alarm_manager] Android Code Inspection and Clean up #3020

hamdikahloun commented Sep 11, 2020 •

edited

dnfield Sep 12, 2020

hamdikahloun Sep 12, 2020 •

edited

dnfield Sep 12, 2020

hamdikahloun Sep 12, 2020

hamdikahloun Sep 12, 2020

dnfield Sep 12, 2020

hamdikahloun Sep 12, 2020

hamdikahloun Sep 12, 2020 •

edited

dnfield left a comment

		@@ -1 +1,2 @@
		org.gradle.jvmargs=-Xmx1536M
		android.enableR8=true

		@@ -0,0 +1,5 @@
		distributionBase=GRADLE_USER_HOME
		distributionPath=wrapper/dists

[android_alarm_manager] Android Code Inspection and Clean up #3020

[android_alarm_manager] Android Code Inspection and Clean up #3020

Conversation

hamdikahloun commented Sep 11, 2020 • edited

Description

Checklist

Breaking Change

dnfield Sep 12, 2020

Choose a reason for hiding this comment

hamdikahloun Sep 12, 2020 • edited

Choose a reason for hiding this comment

dnfield Sep 12, 2020

Choose a reason for hiding this comment

hamdikahloun Sep 12, 2020

Choose a reason for hiding this comment

hamdikahloun Sep 12, 2020

Choose a reason for hiding this comment

dnfield Sep 12, 2020

Choose a reason for hiding this comment

hamdikahloun Sep 12, 2020

Choose a reason for hiding this comment

hamdikahloun Sep 12, 2020 • edited

Choose a reason for hiding this comment

dnfield left a comment

Choose a reason for hiding this comment

hamdikahloun commented Sep 11, 2020 •

edited

hamdikahloun Sep 12, 2020 •

edited

hamdikahloun Sep 12, 2020 •

edited