This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[android_intent] Android Code Inspection and Clean up #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdikahloun
requested review from
matthew-carroll and
mklim
as code owners
hamdikahloun
changed the title
dnfield
reviewed
Sep 17, 2020
Comment on lines
86
to
91
| (packageName != null | ||
| && component != null | ||
| && !TextUtils.isEmpty(packageName) | ||
| && !TextUtils.isEmpty(component)) | ||
| ? new ComponentName(packageName, component) | ||
| : null; |
There was a problem hiding this comment.
nit: I would find this easier to read as a regular declaration followed by an if statement. This seems like a lot of logic for a ternary.
dnfield
reviewed
Sep 17, 2020
| bundle.putStringArrayList(key, (ArrayList<String>) value); | ||
| } else if (isStringKeyedMap(value)) { | ||
| bundle.putBundle(key, convertArguments((Map<String, ?>) value)); | ||
| } else if (integers(value) != null) { |
There was a problem hiding this comment.
nit: I think I prefer the old name of these - I'm a bit surprised to see a function named integers or strings or map.
I also wonder if we can just somehow avoid traversing the array twice and creating the object twice.
|
If it passes pre-submit then you're good |
|
@dnfield |
yasargil
added a commit
to yasargil/plugins
that referenced
this pull request
Oct 8, 2020
* master: [in_app_purchase] Android Code Inspection and Clean up (flutter#3120) Android Code Inspection and Clean up (flutter#3117) [in_app_purchase] Fix finishing purchases upon payment cancellation (flutter#3106) [google_maps_flutter_web] Fix convert.dart issues (flutter#3093) [multiple] Opt-out tests of null-safety (flutter#3113) [webview_flutter] add public documentation. (flutter#3114) in_app_purchase: started supported null as a parameter for the sandbox arguement (flutter#3110) [connectivity] Android Code Inspection and Clean up (flutter#3051) [android_intent] Android Code Inspection and Clean up (flutter#3043) Remove `io.flutter.embedded_views_preview` from README [google_maps_flutter] Fix headline in the readme (flutter#3100) [webview_flutter] Add new entrypoint that uses hybrid composition on Android (flutter#3067) [google_maps_flutter] Out of developers preview, bump to 1.0.0 (flutter#3091) [url_launcher_web] Move third_party under src. (flutter#3080) [plugin_platform_interface] Fix homepage in pubspec.yaml (flutter#3088) [connectivity_for_web] Fix homepage in pubspec.yaml (flutter#3089) [in_app_purchase] Update typo in example main.dart (flutter#3073)
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle deprecation & unchecked warning as error
Avoiding uses or overrides a deprecated API in FlutterBackgroundExecutor.java
Related Issues
flutter/flutter#65970
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?