This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[shared_preferences] Add iOS stub to shared_preferences_windows #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared_preferences supports versions older than 1.18, so this plugin needs the iOS stub to prevent breaking iOS projects via transitive dependencies when shared_prefences endorses the Windows implementation.
|
I managed to forget this in the initial version of all three plugins :P |
This was referenced Sep 20, 2020
danielroek
pushed a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Oct 1, 2020
…ter#3058) shared_preferences supports versions older than 1.18, so this plugin needs the iOS stub to prevent breaking iOS projects via transitive dependencies when shared_preferences endorses the Windows implementation.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…ter#3058) shared_preferences supports versions older than 1.18, so this plugin needs the iOS stub to prevent breaking iOS projects via transitive dependencies when shared_preferences endorses the Windows implementation.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…ter#3058) shared_preferences supports versions older than 1.18, so this plugin needs the iOS stub to prevent breaking iOS projects via transitive dependencies when shared_preferences endorses the Windows implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shared_preferences supports versions older than 1.18, so this plugin
needs the iOS stub to prevent breaking iOS projects via transitive
dependencies when shared_preferences endorses the Windows implementation.
Related Issues
flutter/flutter#41719
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?