This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[integration_test] Test drivers should end with _test.dart
#3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahaog
force-pushed
the
test-driver-rename
branch
from
7b516a3
to
22c31d3
Compare
|
Please ignore the CI failures for now – I have opened flutter/plugin_tools#108 which will update the plugin tools to support this. |
dnfield
approved these changes
Sep 21, 2020
|
I'm not sure why this is failing, looks like things passed? |
|
Thanks! It is failing because the CI script doesn't support this yet – please see flutter/plugin_tools#108! |
This makes globbing by tooling easier. Also fix the documentation for running them natively with the Android and iOS tool.
jiahaog
force-pushed
the
test-driver-rename
branch
2 times, most recently
from
e56ae62
to
06d1e81
Compare
jiahaog
force-pushed
the
test-driver-rename
branch
from
0f4e3a6
to
26f5d28
Compare
|
I moved just the failure test to the test_driver directory to avoid globbing for that, and added a note as well. As mentioned on #hackers-ecosystem, the failure on master is a flake with Cocoapods, so landing this. |
danielroek
pushed a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Oct 1, 2020
…#3063) This makes globbing by tooling easier. Also fix the documentation for running them natively with the Android and iOS tool.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…#3063) This makes globbing by tooling easier. Also fix the documentation for running them natively with the Android and iOS tool.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…#3063) This makes globbing by tooling easier. Also fix the documentation for running them natively with the Android and iOS tool.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working on tooling to migrate existing apps (draft #3046), I think it makes more sense for the driver files to keep the _test.dart suffix. This makes globbing by tooling easier.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?