[video_player] Migrate video player to null safety #3165
Conversation
|
|
||
| /// The total duration of the video. | ||
| /// | ||
| /// Is null when [initialized] is false. | ||
| /// The duration is zero if the video hasn't been initialized. |
There was a problem hiding this comment.
nits:
| /// The duration is zero if the video hasn't been initialized. | |
| /// The duration is [Duration.zero] if the video hasn't been initialized. |
|
|
||
| /// The [size] of the currently loaded video. | ||
| /// | ||
| /// Is null when [initialized] is false. | ||
| final Size size; | ||
|
|
||
| /// Indicates whether or not the video has been loaded and is ready to play. | ||
| bool get initialized => duration != null; | ||
| final bool isInitialized; |
There was a problem hiding this comment.
Why did we need to make this name change? Feels like we can make it as non-breaking as possible?
Although I do agree that isInitialized is a better name. So your call.
| @@ -340,19 +356,18 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> { | |||
| } | |||
|
|
|||
| @override | |||
| // ignore: must_call_super | |||
| } | ||
| _isDisposed = true; | ||
| super.dispose(); | ||
| _lifeCycleObserver.dispose(); |
There was a problem hiding this comment.
Looks like the logic here is changed, is it related to null-safety migration?
| if (_isDisposed) { | ||
| return; | ||
| } | ||
| _updatePosition(newPosition); | ||
| _updatePosition(newPosition!); |
There was a problem hiding this comment.
can newPosition here be null?
There was a problem hiding this comment.
No, but I changed the code, so it's more readable. The Analyzer can figure out that newPosition! can safely be newPosition if you have a null check earlier.
| @@ -545,7 +560,7 @@ class _VideoAppLifeCycleObserver extends Object with WidgetsBindingObserver { | |||
| final VideoPlayerController _controller; | |||
|
|
|||
| void initialize() { | |||
| WidgetsBinding.instance.addObserver(this); | |||
| WidgetsBinding.instance!.addObserver(this); | |||
There was a problem hiding this comment.
Can WidgetsBinding.instance be null?
There was a problem hiding this comment.
no. runApp() calls WidgetsFlutterBinding.ensureInitialized().
| assetUrl = 'packages/${dataSource.package}/$assetUrl'; | ||
| } | ||
| // 'webOnlyAssetManager' is only in the web version of dart:ui | ||
| // ignore: undefined_prefixed_name | ||
| assetUrl = ui.webOnlyAssetManager.getAssetUrl(assetUrl); | ||
| ui.webOnlyAssetManager.getAssetUrl(assetUrl); | ||
| assetUrl = ''; |
There was a problem hiding this comment.
Not sure why we need this line, could you elaborate?
blasten
force-pushed
the
video_player_nnbd
branch
from
3454b4e
to
50afefb
Compare
Migrates video player to null safety.
I made some API changes like the use of
Duration.zero/Size.zeroinstead ofnullfor defaults inVideoPlayerValueandCaption.