Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Added documentation about video not working correctly on Android emulators #3180

Merged
merged 6 commits into from Oct 28, 2020

Conversation

anniek-valk
Copy link
Contributor

@anniek-valk anniek-valk commented Oct 21, 2020

Description

To make sure no developers try to find out why the a video with audio on an Android emulator isn't working properly, I added it to the README.md.

Related Issues

Issue 42309

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 21, 2020
@anniek-valk anniek-valk marked this pull request as draft October 21, 2020 14:04
packages/camera/README.md Outdated Show resolved Hide resolved
valconetti and others added 4 commits October 22, 2020 13:24
…ter-plugins into issue-42309

� Conflicts:
�	packages/camera/CHANGELOG.md
�	packages/camera/README.md
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
@anniek-valk anniek-valk changed the title [camera] Added information of video not working correctly on Android emulators… [camera] Added documentation about video not working correctly on Android emulators Oct 23, 2020
@anniek-valk anniek-valk marked this pull request as ready for review October 23, 2020 08:12
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nit

packages/camera/README.md Outdated Show resolved Hide resolved
Co-authored-by: Maurice Parrish <bmparr@google.com>
@mvanbeusekom mvanbeusekom merged commit 1a38ddf into flutter:master Oct 28, 2020
yasargil added a commit to yasargil/plugins that referenced this pull request Oct 30, 2020
* master: (48 commits)
  [video_player] Add toString() to Caption (flutter#3233)
  [google_maps_flutter_web] Show one InfoWindow at a time. (flutter#3224)
  [in_app_purchase] Bump version (flutter#3227)
  [google_maps_flutter] Overhaul lifecycle management in GoogleMapsPlugin (flutter#3213)
  [in_app_purchase] Remove the custom analysis options, fix failing lints. (flutter#3220)
  [video_player]Fixes Playing video from asset on Android (flutter#3123)
  [camera] Added documentation about video not working correctly on Android emulators (flutter#3180)
  Revert "update api"
  update api
  [wifi_info_flutter] Method channel name fixed for android (flutter#3207)
  [share] Fix bug on iPad where `origin` is null and enable XCUITests in the repo (flutter#3210)
  [google_maps_flutter] Clean up google_maps_flutter plugin (flutter#3206)
  Exclude generated_plugin_registrant.cc (flutter#3198)
  broaden the constraint on package:vm_service (flutter#3208)
  Remove unnecessary work around from test in prep for vm_service migration (flutter#3209)
  Add windows directory to examples (flutter#3149)
  [video_player] Upgrade ExoPlayer (flutter#3204)
  [android_alarm_manager] Removed deprecated display1 (flutter#3200)
  [Connectivity] wifi removal (flutter#3173)
  [wifi_info_flutter] make it ready for initial 1.0.0 release  (flutter#3191)
  ...
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…roid emulators (flutter#3180)

* Added information of video not working correctly on Android emulators to `README.md`.

* Changed up the text and added a link

* Version fix

* Update packages/camera/README.md

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>

* Improve grammar as suggested

Co-authored-by: Maurice Parrish <bmparr@google.com>

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Co-authored-by: Maurice Parrish <bmparr@google.com>
@mvanbeusekom mvanbeusekom deleted the issue-42309 branch September 21, 2021 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants