[image_picker] fix camera on Android 11

[Bubu]

Description

resolveActivity(intent) might return false on android 11+ even though startActivity(intent) would succeed.
Instead of introducing a entry we can just try to start the
activity and catch the exception if that doesn't work.

See here for a longer form explanation: https://cketti.de/2020/09/03/avoid-intent-resolveactivity/

Related Issues

Fixes flutter/flutter#85599
flutter/flutter#62669

Some more info on the android 11 behaviour change: flutter/flutter#63727 (comment)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[Bubu]

@googlebot I signed it!

[Bubu]

Hi, is there anything else I can do here?

[zigapovhe]

@cyanglaz Is this ready to merge?
@Bubu can you fix conflict with the CHANGELOG.md?

[Bubu]

Rebased on master and fixed conflicts.

[Bubu]

This branch has conflicts that must be resolved

sigh Any chance that someone might look at this? 🤔

[Bubu]

Any chance to get this looked at?

[stuartmorgan]

Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

@mvanbeusekom Could you add this review to your list?

[renefloor]

Looks like a good change to me, especially because Google also recommends catch (e: ActivityNotFoundException) in their blog post.

However, I think it would be better to clean the empty file.

[renefloor]

LGTM

[renefloor]

@Bubu can you bring your branch up to date with master once more and update the changelog/pubspec? I'm afraid 0.8.1+1
is already taken :)

I think there is also 1 broken test (maybe that is new since you fixed the tests).

/tmp/cirrus-ci-build/packages/image_picker/image_picker/example/android/app/src/test/java/io/flutter/plugins/imagepicker/ImagePickerDelegateTest.java:197: error: cannot find symbol
    when(mockIntentResolver.resolveActivity(any(Intent.class))).thenReturn(true);

[Bubu]

I think there is also 1 broken test (maybe that is new since you fixed the tests).

Ugh, there is... It's been so long since I wrote the changes to the tests here... 🙈 . Let me see if I can make it work again :D.

[Bubu]

@renefloor I can't figure out how to run the tests successfully locally (any pointers for that?). I still pushed a commit that should fix it and also (hopefully) resolved the conflicts. 🎉

[renefloor]

@Bubu Currently takeImageWithCamera_WhenHasCameraPermission_AndNoActivityToHandleCameraIntent_FinishesWithNoCamerasAvailableError in ImagePickerDelegateTest is failing with java.io.IOException: No such file or directory.

That's because the test doesn't expect a file to be created (because the camera is not available), so the file system was not mocked.

I added this after line 183 in that test:

    MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class);
    mockStaticFile
            .when(() -> File.createTempFile(any(), any(), any()))
            .thenReturn(new File("/tmpfile"));

and I added the following line at the end of the test:

    mockStaticFile.close();

I cannot really comment this as a suggestion on your PR as these are not lines that changed, but I hope it makes sense. The complete test becomes:

  @Test
  public void
      takeImageWithCamera_WhenHasCameraPermission_AndNoActivityToHandleCameraIntent_FinishesWithNoCamerasAvailableError() {
    when(mockPermissionManager.isPermissionGranted(Manifest.permission.CAMERA)).thenReturn(true);

    MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class);
    mockStaticFile
            .when(() -> File.createTempFile(any(), any(), any()))
            .thenReturn(new File("/tmpfile"));

    doThrow(ActivityNotFoundException.class)
        .when(mockActivity)
        .startActivityForResult(any(Intent.class), anyInt());
    ImagePickerDelegate delegate = createDelegate();
    delegate.takeImageWithCamera(mockMethodCall, mockResult);

    verify(mockResult)
        .error("no_available_camera", "No cameras available for taking pictures.", null);
    verifyNoMoreInteractions(mockResult);
    mockStaticFile.close();
  }

It would me nice to also add mockStaticFile.close(); in takeImageWithCamera_WritesImageToCacheDirectory.

[Bubu]

🤞

(I'm flying blind here, when I try to run the tests I get a huge amount of unrelated build errors instead. Let's just hope it works this time :))

[Bubu]

We are now failing at a different test. I don't quite understand why my MR would be changing the behavior for that test. takeImageWithCamera_WhenHasCameraPermission_AndAnActivityCanHandleCameraIntent_LaunchesTakeWithCameraIntent should have been creating files even before this change?

Did some merge go wrong here?

[renefloor]

I'm at my phone at the moment, but make sure to open image_picker/example/android and not image_picker/android. You might need to run the flutter example once or maybe you are missing parts of the SDK.

[Bubu]

Rebased. Let's see how it goes :).

[stuartmorgan]

@blasten Do you want to do a final review on this?

[Bubu]

Hey everyone, any progress here? :-)

[blasten]

requires to catch the exception

[ManuLpz4]

Please ♥️

UPDATE: You can temporally fix this issue targeting your app to sdk 29 :)

[stuartmorgan]

@Bubu Could you resolve the conflicts so we move forward with landing this?

[Bubu]

@stuartmorgan hopefully all done correctly.

[Bubu]

There's now conflicts again here now... 🤔

[stuartmorgan]

That's my mistake for not following up after merging in master to fix the infra issues.