Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] Allow empty type groups #3261

Merged
merged 1 commit into from Nov 11, 2020

Conversation

stuartmorgan
Copy link
Contributor

Description

This was restricted under the assumption that there was no reason for an
empty group to exist, but that's not actually true; on platforms with
selectable groups in the native UI, it may be useful to provide
specific options as well as a fallback option (e.g., "Text files" and
"All files").

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This was restricted under the assumption that there was no reason for an
empty group to exist, but that's not actually true; on platforms with
selectable groups in the native UI, it may be useful to provide
specific options as well as a fallback option (e.g., "Text files" and
"All files").
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this change if my suggestion above is not a good way to go!

@ditman ditman merged commit 06530f9 into flutter:master Nov 11, 2020
fesp pushed a commit to fesp/plugins that referenced this pull request Nov 11, 2020
This was restricted under the assumption that there was no reason for an empty group to exist, but that's not actually true; on platforms with selectable groups in the native UI, it may be useful to provide specific options as well as a fallback option (e.g., "Text files" and "All files").
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
This was restricted under the assumption that there was no reason for an empty group to exist, but that's not actually true; on platforms with selectable groups in the native UI, it may be useful to provide specific options as well as a fallback option (e.g., "Text files" and "All files").
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants