Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Ios support documentation #3335

Merged
merged 3 commits into from Dec 16, 2020

Conversation

danielroek
Copy link
Contributor

Description

Updated the README about the minimum iOS version as proposed here.

Related Issues

PR #2753 should be closed after merging this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have one small nit regarding the sentence. Would be nice if you can have a look at it.

packages/camera/camera/README.md Outdated Show resolved Hide resolved
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit 05879a3 into flutter:master Dec 16, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
NickalasB added a commit to NickalasB/plugins that referenced this pull request Dec 17, 2020
* master:
  [camera] Ios support documentation  (flutter#3335)
  Remove custom null safety analysis_options files (flutter#3339)
  [webview_flutter] Added 'allowsInlineMediaPlayback' property (flutter#3334)
  [camera_platform_interface] Add torch definition to the FlashModes enum  (flutter#3326)
  [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flutter#3271)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/pubspec.yaml
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 29, 2020
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
* updated README.md to notify about no < iOS10 support

* Version bump

* Improved explanation

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
* updated README.md to notify about no < iOS10 support

* Version bump

* Improved explanation

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
@mvanbeusekom mvanbeusekom deleted the ios_platform_version branch September 21, 2021 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants