This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Add an option to set the background color of the webview #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
added
the
p: webview_flutter
|
So close to have this feature ... waiting for month as others !!! Hope this merge will be accepted and in the next Webview version ! |
e-adrien
force-pushed
the
webview-transparent-background
branch
from
e1a8847
to
f5e0752
Compare
e-adrien
force-pushed
the
webview-transparent-background
branch
from
f5e0752
to
50463ad
Compare
|
There are conflicts, seems @e-adrien you need to rebase again. 🤪 |
e-adrien
force-pushed
the
webview-transparent-background
branch
from
50463ad
to
073455d
Compare
|
@crizant done 😄 I'll try to rebase it more regularly 😅 |
e-adrien
force-pushed
the
webview-transparent-background
branch
from
073455d
to
4fd8511
Compare
e-adrien
force-pushed
the
webview-transparent-background
branch
from
4fd8511
to
a513bb1
Compare
|
Any updates? |
3 tasks
e-adrien
force-pushed
the
webview-transparent-background
branch
from
a513bb1
to
5e62bc2
Compare
e-adrien
requested review from
bparrishMines,
cyanglaz,
ditman,
gaaclarke and
LHLL
as code owners
github-actions
bot
added
p: android_alarm_manager
p: android_intent
p: battery
11 tasks
|
FYI the analyzer issue you are hitting is unrelated to your change; I just landed a fix for it. |
stuartmorgan
pushed a commit
that referenced
this pull request
Dec 2, 2021
…m interface (#4567) Part of #3431 Part of flutter/flutter#29300
This was referenced Dec 3, 2021
stuartmorgan
pushed a commit
that referenced
this pull request
Dec 4, 2021
) This PR add an option to set the background color of the iOS webview. Part of #3431 Part of flutter/flutter#29300
stuartmorgan
pushed a commit
that referenced
this pull request
Dec 6, 2021
…#4569) This PR add an option to set the background color of the Android webview. Part of: #3431 Part of: flutter/flutter#29300
|
The individual components have all landed (the Android implementation will auto-publish once the post-submit tests finish), so this can now be reduced down to just the |
Thanks. I will open a PR when the android package will be published. |
11 tasks
This was referenced Dec 7, 2021
stuartmorgan
approved these changes
Dec 7, 2021
stuartmorgan
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…m interface (flutter#4567) Part of flutter#3431 Part of flutter/flutter#29300
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…utter#4570) This PR add an option to set the background color of the iOS webview. Part of flutter#3431 Part of flutter/flutter#29300
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…flutter#4569) This PR add an option to set the background color of the Android webview. Part of: flutter#3431 Part of: flutter/flutter#29300
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…m interface (flutter#4567) Part of flutter#3431 Part of flutter/flutter#29300
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…utter#4570) This PR add an option to set the background color of the iOS webview. Part of flutter#3431 Part of flutter/flutter#29300
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…flutter#4569) This PR add an option to set the background color of the Android webview. Part of: flutter#3431 Part of: flutter/flutter#29300
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add an option to set a transparent background for the webview.
There are already 2 outdated PR for the same feature :
I took the previous PR made by @crizant and rebase it.
It fixes this issue :