Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Ensure that channel.invokeMethod runs on the main thread #3444

Merged
merged 6 commits into from
Jan 21, 2021
Merged

[camera] Ensure that channel.invokeMethod runs on the main thread #3444

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e398a0
call invokeMethod on the main thread
Jan 12, 2021
81b29a1
Merge branch 'master' into camera-v0.6.4+5hotfix
jsroest Jan 21, 2021
3bacd2b
apply fix that resolves crash when the caller is not running on the m…
jsroest Jan 21, 2021
ca3977d
format according google rules => pub global run flutter_plugin_tools …
jsroest Jan 21, 2021
f25b64a
Increase version, add info to CHANGELOG.md
jsroest Jan 21, 2021
cc146e2
Change message in CHANGELOG.md to be more descriptive
jsroest Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.7.0+1

* Fix issue: [camera] [crash] Methods marked with @UiThread must be executed on the main thread #72340
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It would be nice if we can update this to form a correct sentence. Maybe something like this:

Suggested change
* Fix issue: [camera] [crash] Methods marked with @UiThread must be executed on the main thread #72340
* Ensure communication from JAVA to Dart is done on the main UI thread.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as you requested


## 0.7.0

* BREAKING CHANGE: `CameraValue.aspectRatio` now returns `width / height` rather than `height / width`. [(commit)](https://github.com/flutter/plugins/commit/100c7470d4066b1d0f8f7e4ec6d7c943e736f970)
Expand Down
20 changes: 18 additions & 2 deletions packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/DartMessenger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

package io.flutter.plugins.camera;

import android.os.Handler;
import android.os.Looper;
import android.text.TextUtils;
import androidx.annotation.Nullable;
import io.flutter.embedding.engine.systemchannels.PlatformChannel;
Expand Down Expand Up @@ -104,7 +106,14 @@ void send(CameraEventType eventType, Map<String, Object> args) {
if (cameraChannel == null) {
return;
}
cameraChannel.invokeMethod(eventType.method, args);
new Handler(Looper.getMainLooper())
.post(
new Runnable() {
@Override
public void run() {
cameraChannel.invokeMethod(eventType.method, args);
}
});
}

void send(DeviceEventType eventType) {
Expand All @@ -115,6 +124,13 @@ void send(DeviceEventType eventType, Map<String, Object> args) {
if (deviceChannel == null) {
return;
}
deviceChannel.invokeMethod(eventType.method, args);
new Handler(Looper.getMainLooper())
.post(
new Runnable() {
@Override
public void run() {
deviceChannel.invokeMethod(eventType.method, args);
}
});
}
}
2 changes: 1 addition & 1 deletion packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera
description: A Flutter plugin for getting information about and controlling the
camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
and streaming image buffers to dart.
version: 0.7.0
version: 0.7.0+1
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera

dependencies:
Expand Down