Batch support for Firestore #361

Skylled · 2018-01-12T03:27:09Z

I've done some initial testing on Android, including a sync call to an operation followed by an async call.

iOS support is here but needs to be tested.

collinjackson

Thanks for the contribution! I have some minor feedback

collinjackson · 2018-01-13T01:37:08Z

packages/cloud_firestore/ios/Classes/CloudFirestorePlugin.m

+    [batch deleteDocument:reference];
+    result(nil);
+  } else if ([@"Batch#commit" isEqualToString:call.method]) {
+    // TODO:


Did you mean to leave this empty TODO?

I think you should remove the batches from the NSDictionary once they are committed

collinjackson · 2018-01-13T01:37:39Z

...e/android/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java

+          WriteBatch batch = batches.get(handle);
+          Task<Void> task = batch.commit();
+          addDefaultListeners("commit", task, result);
+          break;


I think you should remove the batches from the SparseArray once they are committed.

collinjackson · 2018-01-13T01:38:51Z

packages/cloud_firestore/lib/src/write_batch.dart

+  final List<Future<Null>> _actions = <Future<Null>>[];
+
+  /// Indicator to whether or not this [WriteBatch] has been committed.
+  bool committed = false;


I think this should be a private property to follow the convention of the Firebase SDK

collinjackson · 2018-01-13T01:40:09Z

...e/android/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java

@@ -36,9 +37,11 @@

  // Handles are ints used as indexes into the sparse array of active observers
  private int nextHandle = 0;


Can you please rename this nextListenerHandle to better distinguish it from the property below?

Skylled · 2018-01-13T02:07:45Z

Thanks for the feedback. Good catch on removing from the Arrays. That was a memory leak waiting to happen.

Can you confirm for me that it works as expected on iOS? I'm just going by example/instinct with the ObjC code.

Edit: Travis definitely doesn't like it, so that's not a good sign.

Skylled · 2018-01-24T21:56:22Z

Apologies for the messy ObjC. Thanks for the cleanup, @collinjackson

collinjackson · 2018-02-05T22:07:04Z

After taking a second look at this, I think we want batches to be produced by an instance method of Firestore rather than a constructor. This will more closely match the iOS and Android APIs and will make it easier for us to add multiple app support to this plugin in the future.

Skylled · 2018-02-05T22:38:54Z

Love the design so far.

Will anything need to change on the native side to make that possible? Presently we're using FirebaseFirestore.getInstance. Or will we revisit it with multi-app support?

collinjackson · 2018-02-05T22:44:41Z

When we implement multiple app support we can fix the native side to look up the appropriate Firestore instance. The API on the Dart side won't change so we won't need to worry about breaking anyone.

bramvbilsen · 2018-02-26T22:28:17Z

Any idea for when this will be released?

Purus · 2018-03-07T07:22:05Z

Looking for this too..

For uniformity with Android/iOS classes Rename file parts

…fixing

tzvc · 2019-03-13T01:44:02Z

is there any docs for this? :)

ShiroYacha · 2019-07-27T15:47:23Z

@theochampion guess you can check https://github.com/flutter/plugins/blob/master/packages/cloud_firestore/lib/src/write_batch.dart

googlebot added the cla: yes label Jan 12, 2018

Hixie requested a review from collinjackson January 12, 2018 20:59

collinjackson self-assigned this Jan 13, 2018

collinjackson reviewed Jan 13, 2018

View reviewed changes

collinjackson force-pushed the firestore-batches branch from 1b7f1c2 to 6c1ad58 Compare February 5, 2018 21:54

Hixie added the needs love label Mar 20, 2018

Kyle Bradshaw and others added 17 commits March 23, 2018 10:54

Initial (untested) batch support

ad4d9cb

Rename Batch to WriteBatch

b12c1e5

For uniformity with Android/iOS classes Rename file parts

Block double commits

d86f45b

Add documentation

b73e635

Standardize method and class names

e09f0c2

Add some tests

d78b066

Fixes from feedback

7528891

Formatting fixes for Travis

8a7e63f

Build fixes for iOS

5c3820a

Update CHANGELOG.md

e216928

Fix example app

77ea536

Fix compile error in Java

3857d66

Update copyright date

6a7ecb8

Update API to be more like the native SDK

374c61a

Fix formatting and build errors

6c0c6f4

Remove duplicated code

8ff11fc

Fix merge damage in test

22cd361

Fixes for Dart 2 types

70de28e

collinjackson force-pushed the firestore-batches branch from 614e80e to 70de28e Compare March 23, 2018 22:25

Update CHANGELOG to remove reference to example that no longer needs …

27b5cc9

…fixing

collinjackson approved these changes Mar 23, 2018

View reviewed changes

Fix formatting error introduced by merge damage

216597f

collinjackson merged commit d0934c0 into flutter:master Mar 23, 2018

slightfoot pushed a commit to slightfoot/plugins that referenced this pull request Jun 5, 2018

Batch support for Firestore (flutter#361)

ab1f281

Hixie removed the needs love label Oct 24, 2018

Hixie unassigned collinjackson Oct 24, 2018

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020

Batch support for Firestore (flutter#361)

c75a99b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch support for Firestore #361

Batch support for Firestore #361

Skylled commented Jan 12, 2018

collinjackson left a comment

collinjackson Jan 13, 2018

collinjackson Jan 13, 2018

collinjackson Jan 13, 2018

collinjackson Jan 13, 2018

Skylled commented Jan 13, 2018 •

edited

Loading

Skylled commented Jan 24, 2018

collinjackson commented Feb 5, 2018

Skylled commented Feb 5, 2018 •

edited

Loading

collinjackson commented Feb 5, 2018

bramvbilsen commented Feb 26, 2018

Purus commented Mar 7, 2018

tzvc commented Mar 13, 2019

ShiroYacha commented Jul 27, 2019

		@@ -36,9 +37,11 @@

		// Handles are ints used as indexes into the sparse array of active observers
		private int nextHandle = 0;

Batch support for Firestore #361

Batch support for Firestore #361

Conversation

Skylled commented Jan 12, 2018

collinjackson left a comment

Choose a reason for hiding this comment

collinjackson Jan 13, 2018

Choose a reason for hiding this comment

collinjackson Jan 13, 2018

Choose a reason for hiding this comment

collinjackson Jan 13, 2018

Choose a reason for hiding this comment

collinjackson Jan 13, 2018

Choose a reason for hiding this comment

Skylled commented Jan 13, 2018 • edited Loading

Skylled commented Jan 24, 2018

collinjackson commented Feb 5, 2018

Skylled commented Feb 5, 2018 • edited Loading

collinjackson commented Feb 5, 2018

bramvbilsen commented Feb 26, 2018

Purus commented Mar 7, 2018

tzvc commented Mar 13, 2019

ShiroYacha commented Jul 27, 2019

Skylled commented Jan 13, 2018 •

edited

Loading

Skylled commented Feb 5, 2018 •

edited

Loading