This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Multiple image support #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroek
force-pushed
the
image_picker_multi_image_android
branch
from
3d24faa
to
db47a34
Compare
danielroek
force-pushed
the
image_picker_multi_image_android
branch
from
becf7d4
to
e8cf955
Compare
added 2 commits
April 2, 2021 14:49
…dded log for <iOS14 versions;
|
This is really nice! Thanks. Since it is still a draft I will hold off reviewing it. Please ping me when it's ready and you want me to review it :) |
…_image_android # Conflicts: # packages/image_picker/image_picker/CHANGELOG.md # packages/image_picker/image_picker/pubspec.yaml
…' into image_picker_multi_image_android
# Conflicts: # packages/image_picker/image_picker/CHANGELOG.md # packages/image_picker/image_picker/pubspec.yaml
|
Please fix CI. |
|
@renefloor Looks like your comments have been addressed. Do you want to take another look? |
renefloor
reviewed
Jun 22, 2021
| @@ -11,6 +11,9 @@ First, add `image_picker` as a [dependency in your pubspec.yaml file](https://fl | |||
|
|
|||
| ### iOS | |||
|
|
|||
| Starting with version **0.8.1** the iOS implementation uses PHPicker to pick (multiple) images on iOS 14 or higher. | |||
| As a result of implementing PHPicker it becomes impossible to pick HEIC images on the iOS simulator in iOS 14+. This is a known issue. Please test this on a real device, or test with non-HEIC images until Apple solves this issue.[63426347 - Apple known issue](https://www.google.com/search?q=63426347+apple&sxsrf=ALeKk01YnTMid5S0PYvhL8GbgXJ40ZS[…]t=gws-wiz&ved=0ahUKEwjKh8XH_5HwAhWL_rsIHUmHDN8Q4dUDCA8&uact=5) | |||
There was a problem hiding this comment.
This is a Google Search URL, is there a direct link to the Apple issue tracker? I can only find forum threads like this: https://developer.apple.com/forums/thread/658135
There was a problem hiding this comment.
No, there is not an issue tracker. Not one publicly available. It seems those issues can contain private data which is why they are private.
There was a problem hiding this comment.
Is https://developer.apple.com/forums/thread/658135 a better link? @danielroek
| @@ -1,3 +1,8 @@ | |||
| ## 0.8.1 | |||
|
|
|||
| * Add a new method `getMultiImage` to allow picking multiple images on iOS 14 or higher and Android 4.3 or higher. | |||
There was a problem hiding this comment.
Maybe nice to mention what this function does on older devices. Does it pick 1 or does it not work at all?
| @@ -564,6 +625,17 @@ private void finishWithSuccess(String imagePath) { | |||
| clearMethodCallAndResult(); | |||
| } | |||
|
|
|||
| private void finishWithListSuccess(ArrayList<String> imagePaths) { | |||
| if (pendingResult == null) { | |||
There was a problem hiding this comment.
Shouldn't we also call clearMethodCallAndResult(); in this case?
Co-authored-by: Rene Floor <r.floor.1@gmail.com>
Co-authored-by: Rene Floor <r.floor.1@gmail.com>
…w/flutter-plugins into image_picker_multi_image_android
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Jul 10, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
jolmiracle
added a commit
to miracle-as/webview_flutter
that referenced
this pull request
Sep 24, 2021
# Conflicts: # packages/image_picker/image_picker/CHANGELOG.md # packages/image_picker/image_picker/README.md # packages/image_picker/image_picker/example/android/app/src/test/java/io/flutter/plugins/imagepicker/ImagePickerDelegateTest.java # packages/image_picker/image_picker/lib/image_picker.dart # packages/image_picker/image_picker/pubspec.yaml # packages/image_picker/image_picker/test/image_picker_test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements functionality to pick multiple images in iOS14+ and Android.
Fixes #16054
Fixes #82519
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.