Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider_*] code cleanup: sort directives #3823

Merged
merged 2 commits into from Apr 23, 2021
Merged

[path_provider_*] code cleanup: sort directives #3823

merged 2 commits into from Apr 23, 2021

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 23, 2021 •
edited

The upcoming linter release includes a fix to sort_directives that will trigger a host of new violations in plugins.

See, e.g., https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8849192101410026592/+/u/flutter_test_flutter_plugins/stdout

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Apr 23, 2021
@pq pq changed the title sort directives [path_provider_*] code cleanup: sort directives Apr 23, 2021
@pq pq requested a review from goderbauer April 23, 2021 16:42
goderbauer
goderbauer approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after checks are happy :)

packages/path_provider/path_provider/example/integration_test/path_provider_test.dart Show resolved Hide resolved
@pq pq added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 23, 2021
@pq pq merged commit 015a772 into flutter:master Apr 23, 2021
@pq pq deleted the sort_directives branch April 23, 2021 17:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 23, 2021
@engine-flutter-autoroll
015a772 [path_provider_*] code cleanup: sort directives (flutter/plug…
4a650db 
…ins#3823)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Apr 23, 2021
@engine-flutter-autoroll
015a772 [path_provider_*] code cleanup: sort directives (flutter/plug…
2521721 
…ins#3823) (#81056)
@pq pq mentioned this pull request Apr 25, 2021
Closed
9 tasks
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 27, 2021
@pq
Reland "linter 1.4.0"
513c1a1 
This is a reland of 17644ee

Additional supporting changes in flutter (and plugins):

flutter/flutter#81017
flutter/plugins#3823
flutter/flutter#80817
flutter/flutter#80901
flutter/flutter#81210

Additional context in meta linter issue: dart-lang/linter#2609





Original change's description:
> linter 1.4.0
>
> Mitigating PRs:
>
> https://dart-review.googlesource.com/c/sdk/+/196223
> https://dart-review.googlesource.com/c/sdk/+/196180
>
> flutter/flutter#80817
> flutter/flutter#80901
>
>
>
>
>
> Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Change-Id: Ie6b9682a2f54ef039dd7ac9c6a46cb925615acef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196581
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
yasargil added a commit to yasargil/plugins that referenced this pull request Apr 28, 2021
@yasargil
Merge branch 'master' into gmain
58ff4c0 
* master: (79 commits)
  Fix grammatical error in contributing guide (flutter#3217)
  [google_sign_in_web] fix README typos.
  [tool] combine run and runAndExitOnError (flutter#3827)
  [camera] android-rework part 2: Android auto focus feature (flutter#3796)
  [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826)
  Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822)
  [path_provider_*] code cleanup: sort directives (flutter#3823)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  Path provider windows crash fix (flutter#3814)
  [local_auth] docs update (flutter#3103)
  Update PULL_REQUEST_TEMPLATE.md (flutter#3801)
  [quick_actions] handle cold start on iOS correctly (flutter#3811)
  Replace path_provider_linux widget tests with simple unit tests (flutter#3812)
  [sensors] format dart code based on the new dart formatter (flutter#3809)
  [google_sign_in] Fix "pick account" on iOS (flutter#3805)
  [image_picker_platform_interface] Added pickMultiImage (flutter#3782)
  ...
samandmoore added a commit to Betterment/plugins that referenced this pull request May 6, 2021
@samandmoore
Merge remote-tracking branch 'upstream/master' into latest-from-upstream
ee602a9 
* upstream/master: (383 commits)
  Add implement and registerWith method to plugins (flutter#3833)
  Update third_party license checking (flutter#3844)
  [tool] add `all` and `dry-run` flags to publish-plugin command (flutter#3776)
  Re-add bin/ to flutter_plugin_tools (flutter#3839)
  switch from using 'tuneup' to analyze to 'dart analyze' (flutter#3837)
  [in_app_purchase] Federated iOS implementation (flutter#3832)
  Prep the tools for publishing (flutter#3836)
  [in_app_purchase] Make PurchaseDetails.status mandatory (flutter#3831)
  Fix grammatical error in contributing guide (flutter#3217)
  [google_sign_in_web] fix README typos.
  [tool] combine run and runAndExitOnError (flutter#3827)
  [camera] android-rework part 2: Android auto focus feature (flutter#3796)
  [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826)
  Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822)
  [path_provider_*] code cleanup: sort directives (flutter#3823)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@pq @fotiDim
[path_provider_*] code cleanup: sort directives (flutter#3823)
b077111 
* sort directives

* fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
cla: yes p: path_provider platform-linux platform-macos platform-windows waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@pq @goderbauer @stuartmorgan