-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[tool] github action to auto publish (skeleton) #3834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
.github/workflows/release.yml
Outdated
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version. | ||
|
||
- name: "Install Flutter" | ||
# Github aciont doesn't support templates so it is hard to share this snippet with another action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions don't support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
.github/workflows/release.yml
Outdated
- name: Checkout code | ||
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f | ||
with: | ||
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: space after # please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan Updated pre review comments, PTAL
.github/workflows/release.yml
Outdated
- name: Checkout code | ||
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f | ||
with: | ||
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
.github/workflows/release.yml
Outdated
fetch-depth: 0 #fetch all history so the tool can get all the tag to determine version. | ||
|
||
- name: "Install Flutter" | ||
# Github aciont doesn't support templates so it is hard to share this snippet with another action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Still LGTM. (I approved with the previous review.) |
This reverts commit 145b6cf.
This is a skeleton github action, this will be integrated with the auto publish tool script once the tool script is ready.
partially flutter/flutter#81446
Pre-launch Checklist
dart format
. See plugin_tool format)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.