Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Unpin iOS GoogleMaps pod dependency version #3850

Merged
merged 1 commit into from
May 11, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 5, 2021

The plugins and flutter infrastructure has migrated past Xcode 11.5, which is related to the original reason this was pinned.

A failure will look like the original reported flutter/flutter#63447.

Fixes flutter/flutter#63530.
See also #2924

@jmagman jmagman self-assigned this May 5, 2021
@google-cla google-cla bot added the cla: yes label May 5, 2021
@jmagman jmagman marked this pull request as ready for review May 5, 2021 00:37
@jmagman jmagman requested a review from cyanglaz as a code owner May 5, 2021 00:37
@jmagman jmagman requested a review from ditman May 5, 2021 00:49
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 5, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 5, 2021
@cyanglaz
Copy link
Contributor

cyanglaz commented May 5, 2021

@jmagman
I'll do a query for all the PRs with "last-mile" when "Windows-plugins" are fixed, then I'll land all these PRs.

@ditman
Copy link
Member

ditman commented May 5, 2021

Thanks for the fix @jmagman!!

@stuartmorgan
Copy link
Contributor

Windows Plugins has been temporarily disabled due to infra issue; landing.

@stuartmorgan stuartmorgan merged commit 53319eb into flutter:master May 11, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman jmagman deleted the unpin-maps branch June 14, 2022 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants