Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Enable analysis for the tool directory #3853

Merged
merged 3 commits into from May 7, 2021

Conversation

stuartmorgan
Copy link
Contributor

Since the tooling doesn't live in packages/, we're not currently analyzing it. This enables analysis so that we won't have analyzer issues creeping in over time.

To minimize complexity, this just adds it directly to the Cirrus configuration rather than building knowledge of the tool directory into the tool itself.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label May 5, 2021
@stuartmorgan stuartmorgan requested a review from cyanglaz May 5, 2021 18:32
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We can possibly move it to "packages" since it is a package now?

@stuartmorgan
Copy link
Contributor Author

I thought about that, but it's not a plugin, which makes things potentially confusing. (And I don't think we want to move it to flutter/packages for the maintenance reasons we've previously discussed; the heavier use by far is in this repo.)

My thinking was that if it's a one-off, this should be fine, but if we start seeing a pattern of wanting to extend checks to it that are currently package-based we should revisit.

@stuartmorgan
Copy link
Contributor Author

Landing with red Windows Plugins, as we've temporarily disabled that test to re-open the tree while infrastructure issues with that test bot are worked out.

@stuartmorgan stuartmorgan merged commit 19efacc into flutter:master May 7, 2021
@stuartmorgan stuartmorgan deleted the analyze-tool branch May 7, 2021 16:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Since the tooling doesn't live in packages/, we're not currently analyzing it. This enables analysis so that we won't have analyzer issues creeping in over time.

To minimize complexity, this just adds it directly to the Cirrus configuration rather than building knowledge of the tool directory into the tool itself.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants