Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] fix registration links #3859

Merged
merged 4 commits into from
May 10, 2021
Merged

[google_sign_in] fix registration links #3859

merged 4 commits into from
May 10, 2021

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented May 6, 2021

@google-cla google-cla bot added the cla: yes label May 6, 2021
@kevmoo kevmoo requested review from ditman and stuartmorgan May 6, 2021 20:12
stuartmorgan
stuartmorgan suggested changes May 7, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most users are reading the README from pub.dev, so this needs a version and CHANGELOG update so we can publish it.

Also, we don't usually strictly enforce an 80-char limit for .md files; is there a reason you've reformatted the whole file?

@kevmoo
Copy link
Contributor Author

kevmoo commented May 7, 2021

Most users are reading the README from pub.dev, so this needs a version and CHANGELOG update so we can publish it.

Also, we don't usually strictly enforce an 80-char limit for .md files; is there a reason you've reformatted the whole file?

Updated changelog. I was hoping to bump the example, too – before this is published.

RE formatting: my editor does that for me. I find it easier to read. I also cleaned out some bits at the bottom.

Happy to revert unrelated changes if you prefer.

@kevmoo kevmoo requested a review from stuartmorgan May 7, 2021 17:02
stuartmorgan
stuartmorgan approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 10, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • This commit has empty status or empty checks. Please check the Google CLA status is present and Flutter Dashboard application has multiple checks.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 10, 2021
@stuartmorgan
Copy link
Contributor

  • This commit has empty status or empty checks. Please check the Google CLA status is present and Flutter Dashboard application has multiple checks.

Weird. I have no idea what this means.

@kevmoo kevmoo merged commit fcbb0ce into master May 10, 2021
@kevmoo kevmoo deleted the i81847_correct_register_links branch May 10, 2021 20:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
7ae78b8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
1d490ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
d21a572
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
3708176
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
4d249e6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
940555d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
3145961
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
4038e91
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
ae7ee07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
6980b01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
1b3c5b2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
76f5096
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
7a9590b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
5f3b83e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
fcbb0ce [google_sign_in] fix registration links (flutter/plugins#3859)
54b5d14
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@kevmoo @fotiDim
[google_sign_in] fix registration links (flutter#3859)
c95d27d 
Fixes flutter/flutter#81847
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@ditman ditman Awaiting requested review from ditman

Assignees
No one assigned
Labels
cla: yes p: google_sign_in
Projects
None yet
Milestone
No milestone
3 participants
@kevmoo @fluttergithubbot @stuartmorgan