Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Check in macOS example Podfiles #3864

Merged
merged 1 commit into from
May 10, 2021
Merged

Check in macOS example Podfiles #3864

merged 1 commit into from
May 10, 2021

Conversation

stuartmorgan
Copy link
Contributor

PR #3747 stopped ignoring Podfiles and added the missing iOS Podfiles,
but not the macOS Podfiles.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
Check in macOS example Podfiles
ad7ca34 
PR flutter#3747 stopped ignoring Podfiles and added the missing iOS Podfiles,
but not the macOS Podfiles.
@stuartmorgan stuartmorgan requested a review from cyanglaz May 7, 2021 17:16
@google-cla google-cla bot added the cla: yes label May 7, 2021
cyanglaz
cyanglaz approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry that I missed macOS

@stuartmorgan stuartmorgan merged commit 7765fa0 into flutter:master May 10, 2021
@stuartmorgan stuartmorgan deleted the macos-podfiles branch May 10, 2021 16:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
ce058cc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
2720ed0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
4c1f605
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
729bc48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
664b246
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
46addfa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
7b6e2ae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
86cd516
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
2525201
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
b2a99ec
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
81327b8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
0e74b0a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
c4bc6a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
0ffce25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
20c46cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
7765fa0 Check in macOS example Podfiles (flutter/plugins#3864)
cc8583f
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Check in macOS example Podfiles (flutter#3864)
1d5c634 
PR flutter#3747 stopped ignoring Podfiles and added the missing iOS Podfiles,
but not the macOS Podfiles.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes p: connectivity p: integration_test p: package_info p: path_provider p: shared_preferences p: url_launcher platform-macos
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @cyanglaz