Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Expose in_app_purchase_exception.dart correctly #3874

Merged
merged 2 commits into from
May 11, 2021
Merged

[in_app_purchase] Expose in_app_purchase_exception.dart correctly #3874

merged 2 commits into from
May 11, 2021

Conversation

mvanbeusekom
Copy link
Contributor

@mvanbeusekom mvanbeusekom commented May 11, 2021 •
edited

Discovered a small mistake which resulted in the InAppPurchaseException class to not be exposed from the in_app_purchase_platform_interface package. This resulted in implementing packages not being able to compile.

This PR will fix the tree.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 11, 2021
BeMacized
BeMacized approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@BeMacized BeMacized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvanbeusekom mvanbeusekom merged commit eb37661 into flutter:master May 11, 2021
@mvanbeusekom
Copy link
Contributor Author

Landing on red to unblock the tree.

@mvanbeusekom mvanbeusekom deleted the expose_iap_exception branch May 11, 2021 07:18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
157eec6 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
83335d0 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
f94bdf1 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
9bcad3e 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
f7f3a03 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
1d47b08 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
835eada 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
5dd9433 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
e1217ad 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
7648215 
…ctly (flutter/plugins#3874)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
0bb990d 
…ctly (flutter/plugins#3874)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
039512f 
…ctly (flutter/plugins#3874)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
eb37661 [in_app_purchase] Expose in_app_purchase_exception.dart corre…
9a27b16 
…ctly (flutter/plugins#3874)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@mvanbeusekom @fotiDim
[in_app_purchase] Expose in_app_purchase_exception.dart correctly (fl…
dac6009 
…utter#3874)

* Expose in_app_purchase_exception.dart correctly

* Update iOS implementation to use new instance
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BeMacized BeMacized BeMacized approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: in_app_purchase platform-ios
Projects
None yet
Milestone
No milestone
3 participants
@mvanbeusekom @BeMacized @stuartmorgan