Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Update to pub version of in_app_purchase_platform_interface dependency #3879

Merged
merged 3 commits into from
May 11, 2021
Merged

[in_app_purchase] Update to pub version of in_app_purchase_platform_interface dependency #3879

merged 3 commits into from
May 11, 2021

Conversation

mvanbeusekom
Copy link
Contributor

Updates the in_app_purchase_android and in_app_purchase_ios packages to depend on the pub.dev version of the in_app_purchase_platform_interface package (used to be a path reference).

Part of flutter/flutter#78525

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@mvanbeusekom mvanbeusekom requested a review from LHLL as a code owner May 11, 2021 19:31
@google-cla google-cla bot added the cla: yes label May 11, 2021
cyanglaz
cyanglaz approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 11, 2021
@mvanbeusekom mvanbeusekom merged commit 0d62083 into flutter:master May 11, 2021
@mvanbeusekom mvanbeusekom deleted the iap_dependency_update branch May 11, 2021 20:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
c204cc4 
…atform_interface dependency (flutter/plugins#3879)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
6e8e945 
…atform_interface dependency (flutter/plugins#3879)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
98e117e 
…atform_interface dependency (flutter/plugins#3879)
@mvanbeusekom mvanbeusekom mentioned this pull request May 12, 2021
Merged
14 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
d414e42 
…atform_interface dependency (flutter/plugins#3879)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
e75696d 
…atform_interface dependency (flutter/plugins#3879)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
65ac329 
…atform_interface dependency (flutter/plugins#3879)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
e4cc1d0 
…atform_interface dependency (flutter/plugins#3879)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
c811ad9 
…atform_interface dependency (flutter/plugins#3879)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
0d62083 [in_app_purchase] Update to pub version of in_app_purchase_pl…
7a69466 
…atform_interface dependency (flutter/plugins#3879)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@mvanbeusekom @fotiDim
[in_app_purchase] Update to pub version of in_app_purchase_platform_i…
64ff809 
…nterface dependency (flutter#3879)

* Update to pub version of platform interface

* Add missing dependencies

* Renamed podspec file to match new package name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: in_app_purchase platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
2 participants
@mvanbeusekom @cyanglaz