Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[espresso] Minor cleanup #3901

Merged
merged 1 commit into from May 18, 2021

Conversation

stuartmorgan
Copy link
Contributor

  • Stop using the legacy analysis options
  • Switch from "homepage" to "repository" in pubspec.yaml (and fix the link)
  • Add a specific issue query as "issue_tracker" in pubspec.yaml

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

- Stop using the legacy analysis options
- Switch from "homepage" to "repository" in pubspec.yaml
- Add a specific issue query as "issue_tracker" in pubspec.yaml
@stuartmorgan
Copy link
Contributor Author

This updates the version so that I can publish it as a test to make sure this issue_tracker entry will work as expected, before rolling that change out across the repository.

Comment on lines +4 to +5
repository: https://github.com/flutter/plugins/tree/master/packages
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+espresso+label%3A%22p%3A+espresso%22
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 18, 2021
@fluttergithubbot fluttergithubbot merged commit 0f95a81 into flutter:master May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@stuartmorgan stuartmorgan deleted the espresso-cleanup branch May 25, 2021 15:30
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: espresso waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
3 participants