Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Move integration test to null safety for multiple plugins #3932

Merged
merged 4 commits into from May 22, 2021
Merged

Move integration test to null safety for multiple plugins #3932

merged 4 commits into from May 22, 2021

Conversation

stuartmorgan
Copy link
Contributor

Cherry-picks #3646 from the NNBD integration test branch, and updates it for changes on master.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label May 19, 2021
blasten
blasten approved these changes May 20, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan merged commit a864de2 into flutter:master May 22, 2021
@stuartmorgan stuartmorgan deleted the nnbd-integration-tests-misc-from-branch branch May 22, 2021 02:31
stuartmorgan added a commit to stuartmorgan/plugins that referenced this pull request May 22, 2021
@stuartmorgan
[quick-actions] Revert migrating integration tests to NNBD
f447224 
Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (flutter#3932)"
(commit a864de2) since it seems to have
broken XCUITests.
@stuartmorgan stuartmorgan mentioned this pull request May 22, 2021
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2021
@engine-flutter-autoroll
a864de2 Move integration test to null safety for multiple plugins (fl…
8c2e056 
…utter/plugins#3932)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request May 23, 2021
@engine-flutter-autoroll
a864de2 Move integration test to null safety for multiple plugins (fl…
ac8992f 
…utter/plugins#3932) (#83190)
stuartmorgan added a commit that referenced this pull request May 24, 2021
@stuartmorgan
[quick-actions] Revert migrating integration tests to NNBD (#3967)
52033ca 
Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (#3932)"
(commit a864de2) since it seems to have
broken XCUITests.
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Move integration test to null safety for multiple plugins (flutter#3932)
ea44587 
Cherry-picks flutter#3646 from the NNBD integration test branch, and updates it for changes on master.

Co-authored-by: Chris Yang <ychris@google.com>
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
[quick-actions] Revert migrating integration tests to NNBD (flutter#3967
d3db6e3 
)

Reverts the quick_action portion of:
"Move integration test to null safety for multiple plugins (flutter#3932)"
(commit a864de2) since it seems to have
broken XCUITests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: connectivity p: device_info p: image_picker p: in_app_purchase p: quick_actions p: webview_flutter Edits files for a webview_flutter plugin p: wifi_info_flutter platform-android platform-ios platform-macos
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @blasten