Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_android_lifecycle] Migrate integration test to NNBD #3969

Merged
merged 1 commit into from May 25, 2021
Merged

[flutter_plugin_android_lifecycle] Migrate integration test to NNBD #3969

merged 1 commit into from May 25, 2021

Conversation

stuartmorgan
Copy link
Contributor

Enables null safety for the integration test now that it's supported on
master.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
[flutter_plugin_android_lifecycle] Migrate integration test to NNBD
539dd76 
Enables null safety for the integration test now that it's supported on
master.
@stuartmorgan stuartmorgan requested a review from blasten May 23, 2021 00:16
@google-cla google-cla bot added the cla: yes label May 23, 2021
blasten
blasten approved these changes May 24, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan merged commit 6359f0d into flutter:master May 25, 2021
@stuartmorgan stuartmorgan deleted the nnbd-integration-tests-android-lifecycle branch May 25, 2021 10:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 25, 2021
@engine-flutter-autoroll
6359f0d [flutter_plugin_android_lifecycle] Migrate integration test t…
fb4d722 
…o NNBD (flutter/plugins#3969)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
[flutter_plugin_android_lifecycle] Migrate integration test to NNBD (f…
a529387 
…lutter#3969)

Enables null safety for the integration test now that it's supported on
master.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

Assignees
No one assigned
Labels
cla: yes p: flutter_plugin_android_lifecycle
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @blasten