Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fix Restore previous purchases link #3988

Merged
merged 8 commits into from Jun 3, 2021
Merged

[in_app_purchase] Fix Restore previous purchases link #3988

merged 8 commits into from Jun 3, 2021

Conversation

TahaTesser
Copy link
Member

Closes flutter/flutter#83550

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 28, 2021
stuartmorgan
stuartmorgan suggested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small nits. Thanks for fixing this!

packages/in_app_purchase/in_app_purchase/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.0.1+1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/in_app_purchase/in_app_purchase/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.0.1+1

* Update readme
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the actual change to the README

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've just changed the capitalization; please actually describe what in the README you fixed rather than just saying that the README was updated. Just as we describe code fixes, rather than saying "updated the code".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I created flutter/plugins PR. In the past, changelog used to mention "Update README" when making README changes but I like this approach, It is better this way, explain what's actually changed. Thanks, updated

@TahaTesser
Copy link
Member Author

@stuartmorgan
Bumped the version too, thanks for the review

stuartmorgan
stuartmorgan suggested changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing the publish check since you dropped the CHANGELOG update.

stuartmorgan
stuartmorgan suggested changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuartmorgan
stuartmorgan approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button 😝

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 3, 2021
@fluttergithubbot fluttergithubbot merged commit d37fa07 into flutter:master Jun 3, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2021
@engine-flutter-autoroll
d37fa07 [in_app_purchase] Fix Restore previous purchases link (flutte…
5cf2469 
…r/plugins#3988)
@ditman
Copy link
Member

ditman commented Jun 3, 2021

Published https://pub.dev/packages/in_app_purchase/changelog#104

@TahaTesser TahaTesser deleted the fix_iap_readme branch June 3, 2021 19:51
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 4, 2021
@engine-flutter-autoroll
d37fa07 [in_app_purchase] Fix Restore previous purchases link (flutte…
02b21e5 
…r/plugins#3988) (#83932)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@TahaTesser @fotiDim
[in_app_purchase] Fix Restore previous purchases link (flutter#3988)
63f2e37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: in_app_purchase waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@TahaTesser @ditman @stuartmorgan @fluttergithubbot