This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[ios_platform_images] Add iOS unit tests #3997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Jun 2, 2021
@@ -111,7 +163,6 @@ | |||
97C146FD1CF9000F007C117D /* Assets.xcassets */, | |||
97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */, | |||
97C147021CF9000F007C117D /* Info.plist */, | |||
97C146F11CF9000F007C117D /* Supporting Files */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This group was empty.
stuartmorgan
suggested changes
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here as #3998 (review); any test I can imagine for native code here can be written as a native unit test.
jmagman
changed the title
[ios_platform_images] Add iOS unit and UI tests
[ios_platform_images] Add iOS unit tests
Jun 2, 2021
Removed the target. |
stuartmorgan
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
( |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 2, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 2, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RunnerTests
XCTest iOS target to example app that creates the plugin and asserts it's not nil, proving linking is set up correctly.ios_platform_images part of flutter/flutter#83357
https://cirrus-ci.com/task/5061232655859712?logs=xctest#L1734
Pre-launch Checklist
dart format
. See plugin_tool format)[shared_preferences]
///
).