Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ios_platform_images] Add iOS unit tests #3997

Merged
merged 3 commits into from Jun 2, 2021
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 2, 2021

Add RunnerTests XCTest iOS target to example app that creates the plugin and asserts it's not nil, proving linking is set up correctly.

ios_platform_images part of flutter/flutter#83357

https://cirrus-ci.com/task/5061232655859712?logs=xctest#L1734

Test Suite 'IosPlatformImagesTests' passed at 2021-06-02 11:04:09.893.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.011 (0.021) seconds
Test Suite 'RunnerTests.xctest' passed at 2021-06-02 11:04:09.897.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.011 (0.032) seconds

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@@ -111,7 +163,6 @@
97C146FD1CF9000F007C117D /* Assets.xcassets */,
97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */,
97C147021CF9000F007C117D /* Info.plist */,
97C146F11CF9000F007C117D /* Supporting Files */,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This group was empty.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as #3998 (review); any test I can imagine for native code here can be written as a native unit test.

@jmagman jmagman changed the title [ios_platform_images] Add iOS unit and UI tests [ios_platform_images] Add iOS unit tests Jun 2, 2021
@jmagman
Copy link
Member Author

jmagman commented Jun 2, 2021

Same comment here as #3998 (review); any test I can imagine for native code here can be written as a native unit test.

Removed the target.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan
Copy link
Contributor

(format is unhappy though; that will need a minor fix)

@jmagman jmagman merged commit 2d70191 into flutter:master Jun 2, 2021
@jmagman jmagman deleted the ipi-tests branch June 2, 2021 19:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 2, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants