Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Some small documentation fixes #3999

Merged
merged 2 commits into from Jun 2, 2021
Merged

Some small documentation fixes #3999

merged 2 commits into from Jun 2, 2021

Conversation

renefloor
Copy link
Contributor

@renefloor renefloor commented Jun 2, 2021 •
edited

When working on the plugins I encountered some very minor issues in the documentation.

A wrongly formatted url
image

A missing dot:
image

A broken link in the PR template: the plugin_tool format links to https://github.com/flutter/plugins/script/tool/README.md#format-code
image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jun 2, 2021
@renefloor renefloor changed the title Two small documentation fixes Some small documentation fixes Jun 2, 2021
mvanbeusekom
mvanbeusekom approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite build-ipas+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@mvanbeusekom mvanbeusekom merged commit 3623f62 into flutter:master Jun 2, 2021
@mvanbeusekom mvanbeusekom deleted the bugfix/minor-doc-issues branch June 2, 2021 15:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
3623f62 Some small documentation fixes (flutter/plugins#3999)
1e81a31
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@renefloor @fotiDim
Some small documentation fixes (flutter#3999)
1fe7b0a 
* Two small documentation fixes

* Fix url to plugin_tool format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@renefloor @fluttergithubbot @mvanbeusekom