This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Exposing GoogleSignIn Delegate as an interface #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
Mar 1, 2018
| @@ -111,7 +148,7 @@ public void onMethodCall(MethodCall call, Result result) { | |||
| * completed (either successfully or in error). This class provides no synchronization consructs | |||
| * to guarantee such behavior; callers are responsible for providing such guarantees. | |||
| */ | |||
| public static final class Delegate { | |||
| public static final class DelegateImpl implements Delegate { | |||
There was a problem hiding this comment.
This is a breaking change. Rather than having to bump a minor version number, you could keep this Delegate and make the interface (I can't believe I'm saying this...) IDelegate. Then again, I hate myself for having said that, so maybe you just bump the minor version number 😄-- wdyt?
There was a problem hiding this comment.
As discussed offline, it's probably not worth a breaking change to change the name of the Delegate class so I renamed the interface to IDelegate.
|
Updated the class and interface names and increased the version number. |
tvolkert
reviewed
Mar 3, 2018
| @@ -111,7 +148,7 @@ public void onMethodCall(MethodCall call, Result result) { | |||
| * completed (either successfully or in error). This class provides no synchronization consructs | |||
| * to guarantee such behavior; callers are responsible for providing such guarantees. | |||
| */ | |||
| public static final class Delegate { | |||
| public static final class Delegate implements IDelegate { | |||
There was a problem hiding this comment.
Add @Override annotations on the interface methods.
tvolkert
approved these changes
Mar 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the creation of testing versions of this delegate for any other plugin that wants to use it.