Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Pin base image used in CI Dockerfile #4060

Merged
merged 5 commits into from Jun 17, 2021

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Jun 16, 2021

Re-merges the Dockerfiles now that flutter/flutter#84717
has been addressed, and ensures that we are controlling the base image that we use,
rather than it changing automatically on rebuild.

Part of flutter/flutter#84712

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan merged commit 35fba6a into flutter:master Jun 17, 2021
@stuartmorgan stuartmorgan deleted the pin-docker-base-image branch June 17, 2021 00:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Re-merges the Dockerfiles now that flutter/flutter#84717
has been addressed, and ensures that we are controlling the base image that we use,
rather than it changing automatically on rebuild.

Part of flutter/flutter#84712
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants