Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Migrate image_picker to package:cross_file #4073

Merged
merged 44 commits into from Jul 16, 2021

Conversation

BeMacized
Copy link
Member

@BeMacized BeMacized commented Jun 21, 2021

Changed all usages of PickedFile to XFile, to follow the changes made to the platform interface (#4072)

This PR will remain in draft state until the platform interface changes (#4072), as well as the web implementation of it (#4083) have been merged and published, so that the pubspec can be updated properly.

Relevant issue:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
Copy link
Member

ditman commented Jun 22, 2021

image_picker_for_web will need to be landed before the core plugin, so we can update the endorsed version and the platform_interface in one go.

Can you split the changes to image_picker_for_web to a new PR?

@BeMacized
Copy link
Member Author

@ditman Certainly! The changes have been reverted and moved to a new PR: #4083

@google-cla

This comment has been minimized.

@google-cla

This comment has been minimized.

@BeMacized BeMacized marked this pull request as ready for review July 13, 2021 12:36
@BeMacized BeMacized requested a review from cyanglaz as a code owner July 13, 2021 12:36
@google-cla

This comment has been minimized.

@BeMacized
Copy link
Member Author

@ditman It should now be ready to go!

@ditman

This comment has been minimized.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 13, 2021
@ditman

This comment has been minimized.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go. I'm going to give a manual try to the example app in a couple of platforms (android, web) just to quickly verify.

@ditman
Copy link
Member

ditman commented Jul 14, 2021

(Looks good on Web and Android. Note that web has not implemented the "multi image picking" feature.

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 16, 2021
@ditman ditman merged commit dd2d739 into flutter:master Jul 16, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2021
@ditman
Copy link
Member

ditman commented Jul 16, 2021

Thanks @BeMacized!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: image_picker waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
2 participants