Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Prepare plugin repo for binding API improvements. #4136

Merged
merged 1 commit into from Jul 4, 2021
Merged

[url_launcher] Prepare plugin repo for binding API improvements. #4136

merged 1 commit into from Jul 4, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 2, 2021 •
edited

Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@Hixie Hixie mentioned this pull request Jul 2, 2021
Merged
8 tasks
@Hixie Hixie marked this pull request as ready for review July 3, 2021 02:19
stuartmorgan
stuartmorgan approved these changes Jul 3, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Prepare plugin repo for binding API improvements.
649f3f1 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.
@Hixie Hixie added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 4, 2021
@fluttergithubbot fluttergithubbot merged commit 971d6c3 into flutter:master Jul 4, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2021
@engine-flutter-autoroll
971d6c3 Prepare plugin repo for binding API improvements. (flutter/pl…
9442936 
…ugins#4136)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 4, 2021
@engine-flutter-autoroll
971d6c3 Prepare plugin repo for binding API improvements. (flutter/pl…
99731d3 
…ugins#4136) (#85873)
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 5, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
562e45d 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136
@Hixie Hixie mentioned this pull request Jul 5, 2021
Merged
11 tasks
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 6, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
007ee69 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 7, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
18eb135 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 8, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
05659f0 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 9, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
ff4e505 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136, flutter#4137
@Hixie Hixie mentioned this pull request Jul 9, 2021
Merged
11 tasks
Hixie added a commit to Hixie/plugins that referenced this pull request Jul 9, 2021
@Hixie
[various] Prepare plugin repo for binding API improvements
68a5225 
Since plugins also have to work with the stable branch, we can't actually take advantage of the changes right away, so we muddle the issue in the meantime.

Prep for flutter/flutter#83843

See also flutter#4136, flutter#4137
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@Hixie @amantoux
Prepare plugin repo for binding API improvements. (flutter#4136)
6bf31cb
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@Hixie @fotiDim
Prepare plugin repo for binding API improvements. (flutter#4136)
e7d3efa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes p: url_launcher waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@Hixie @stuartmorgan @fluttergithubbot