Remove references to the V1 Android embedding #4160
Conversation
github-actions
bot
added
p: android_alarm_manager
p: android_intent
p: camera
p: connectivity
p: device_info
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
p: sensors
p: share
p: url_launcher
p: video_player
p: webview_flutter
packages/android_intent/example/android/app/src/main/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
|
Could you add an issue link with more context so that someone looking back at this change understands why this was done? (PRs with almost no context have been a significant problem for me as I've tried to investigate why various things in this repository are the way they are). In this case, I thought in our previous discussion this was a multi-phase process where removing tests that we properly support the V1 embedding were going to wait for as long as we actually do support it, but it seems like those are being removed here. |
Done
Ideally. Although, maybe not very urgent if their checks aren't running on CI |
They are running on CI. If we need it for CI, but it's not critical for end users of the plugins, then we should update them but use |
Reverted the change. |
I think that we still should still publish the deprecated plugins, just to ensure that we don't have lingering documentation about the V1 embedding in the repo (so if the change touches the README.md of a plugin, it should be publipshed). (Not sure how "dangerous" is to have old school documentation lying around for some extra weeks/months on those plugins, though.) Also @blasten, the latest change modified 3 plugins of which none are deprecated (I think?). Here's the list of deprecated plugins (or are we talking about a different deprecation?) |
|
ah thanks. I just reverted all of them. |
There was a problem hiding this comment.
I think that we still should still publish the deprecated plugins, just to ensure that we don't have lingering documentation about the V1 embedding in the repo
You mean on pub.dev? It's not in the repo whether we publish it or not.
The plugins are deprecated on pub.dev, so someone reading the instructions about integrating the plugin, on pub.dev, is already ignoring our recommendations. I'm not sure what problem we are solving by having updated instructions on starting to use plugins that we are telling people not to start using...
blasten
force-pushed
the
remove-v1-embedding
branch
from
1967f0b
to
84011a6
Compare
|
PTAL @stuartmorgan |
Issue: flutter/flutter#86578
Remove references to the V1 Android embedding