Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Use -version with java #4171

Merged
merged 1 commit into from Jul 20, 2021
Merged

[flutter_plugin_tools] Use -version with java #4171

merged 1 commit into from Jul 20, 2021

Conversation

stuartmorgan
Copy link
Contributor

Some versions of Java, incuding the one currently installed on Cirrus
macOS machines, don't accept --version.

Fixes flutter/flutter#86675

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
[flutter_plugin_tools] Use -version with java
46e2e02 
Some versions of Java, incuding the one currently installed on Cirrus
macOS machines, don't accept `--version`.

Fixes flutter/flutter#86675
@google-cla google-cla bot added the cla: yes label Jul 20, 2021
@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 20, 2021
@fluttergithubbot fluttergithubbot merged commit a807b5c into flutter:master Jul 20, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
a807b5c [flutter_plugin_tools] Use -version with java (flutter/plugin…
26f3383 
…s#4171)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
a807b5c [flutter_plugin_tools] Use -version with java (flutter/plugin…
ceba4e1 
…s#4171)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
[flutter_plugin_tools] Use -version with java (flutter#4171)
cfbed4f
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@stuartmorgan @amantoux
[flutter_plugin_tools] Use -version with java (flutter#4171)
784e71b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@stuartmorgan @gaaclarke @fluttergithubbot